diff options
| author | Ruben Bridgewater <ruben@bridgewater.de> | 2019-05-11 22:49:36 +0200 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-05-13 16:17:00 -0700 |
| commit | 3aff26428ba0c937afeb022757b1bf067578639d (patch) | |
| tree | c701624b7753dd75ebd7bccad3fc6688ce08cfb1 /test/parallel/test-assert-deep.js | |
| parent | 7294897c77d1e5612efe49aad9f84809ba8d1592 (diff) | |
| download | android-node-v8-3aff26428ba0c937afeb022757b1bf067578639d.tar.gz android-node-v8-3aff26428ba0c937afeb022757b1bf067578639d.tar.bz2 android-node-v8-3aff26428ba0c937afeb022757b1bf067578639d.zip | |
assert: loose deep equal should not compare symbol properties
This is the way it's currently documented and that seems appropriate
for loose equal assertions. The change was not intentional.
Fixes: https://github.com/nodejs/node/issues/27652
PR-URL: https://github.com/nodejs/node/pull/27653
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Diffstat (limited to 'test/parallel/test-assert-deep.js')
| -rw-r--r-- | test/parallel/test-assert-deep.js | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/test/parallel/test-assert-deep.js b/test/parallel/test-assert-deep.js index 013c47121b..a00b26f22b 100644 --- a/test/parallel/test-assert-deep.js +++ b/test/parallel/test-assert-deep.js @@ -639,7 +639,7 @@ assertDeepAndStrictEqual(-0, -0); const b = new Uint8Array(4); a[symbol1] = true; b[symbol1] = false; - assertNotDeepOrStrict(a, b); + assertOnlyDeepEqual(a, b); b[symbol1] = true; assertDeepAndStrictEqual(a, b); // The same as TypedArrays is valid for boxed primitives @@ -649,6 +649,13 @@ assertDeepAndStrictEqual(-0, -0); assertOnlyDeepEqual(boxedStringA, boxedStringB); boxedStringA[symbol1] = true; assertDeepAndStrictEqual(a, b); + // Loose equal arrays should not compare symbols. + const arr = [1]; + const arr2 = [1]; + arr[symbol1] = true; + assertOnlyDeepEqual(arr, arr2); + arr2[symbol1] = false; + assertOnlyDeepEqual(arr, arr2); } assert.throws( |