diff options
author | Anna Henningsen <anna@addaleax.net> | 2018-09-23 19:24:33 +0200 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2018-10-03 13:43:42 -0700 |
commit | d527dde3600655eae7ce0ba5da9263ec4560cd11 (patch) | |
tree | cb9186b8b85a696ec7f916f40fcec935ba86fdc9 /test/parallel/test-accessor-properties.js | |
parent | 2ebdba12297348649620e3d302b156c149d85a6e (diff) | |
download | android-node-v8-d527dde3600655eae7ce0ba5da9263ec4560cd11.tar.gz android-node-v8-d527dde3600655eae7ce0ba5da9263ec4560cd11.tar.bz2 android-node-v8-d527dde3600655eae7ce0ba5da9263ec4560cd11.zip |
src: use JS inheritance for `AsyncWrap`
For all classes descending from `AsyncWrap`, use JS inheritance
instead of manually adding methods to the individual classes.
This allows cleanup of some code around transferring handles
over IPC.
PR-URL: https://github.com/nodejs/node/pull/23094
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-accessor-properties.js')
-rw-r--r-- | test/parallel/test-accessor-properties.js | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/test/parallel/test-accessor-properties.js b/test/parallel/test-accessor-properties.js index ce026313d0..453100d108 100644 --- a/test/parallel/test-accessor-properties.js +++ b/test/parallel/test-accessor-properties.js @@ -32,24 +32,26 @@ const UDP = internalBinding('udp_wrap').UDP; UDP.prototype.fd; }, TypeError); + const StreamWrapProto = Object.getPrototypeOf(TTY.prototype); + // Should not throw for Object.getOwnPropertyDescriptor assert.strictEqual( - typeof Object.getOwnPropertyDescriptor(TTY.prototype, 'bytesRead'), + typeof Object.getOwnPropertyDescriptor(StreamWrapProto, 'bytesRead'), 'object' ); assert.strictEqual( - typeof Object.getOwnPropertyDescriptor(TTY.prototype, 'fd'), + typeof Object.getOwnPropertyDescriptor(StreamWrapProto, 'fd'), 'object' ); assert.strictEqual( - typeof Object.getOwnPropertyDescriptor(TTY.prototype, '_externalStream'), + typeof Object.getOwnPropertyDescriptor(StreamWrapProto, '_externalStream'), 'object' ); assert.strictEqual( - typeof Object.getOwnPropertyDescriptor(UDP.prototype, 'fd'), + typeof Object.getOwnPropertyDescriptor(StreamWrapProto, 'fd'), 'object' ); } |