src: split `LoadEnvironment()` at `startExecution()`

This makes it easier to cater to embedders which wish to skip
the `startExecution()` part.

PR-URL: https://github.com/nodejs/node/pull/25320
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

8 files changed, 1 insertions, 28 deletions

diff --git a/test/message/assert_throws_stack.out b/test/message/assert_throws_stack.out
index 371bd9ff91..cf96ee42c9 100644
--- a/test/message/assert_throws_stack.out
+++ b/test/message/assert_throws_stack.out
@@ -18,4 +18,3 @@ AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
     at *
     at *
     at *
-    at *
diff --git a/test/message/error_exit.out b/test/message/error_exit.out
index 39692a7b6e..6e9b42167d 100644
--- a/test/message/error_exit.out
+++ b/test/message/error_exit.out
@@ -16,4 +16,3 @@ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
     at Function.Module.runMain (internal/modules/cjs/loader.js:*:*)
     at executeUserCode (internal/bootstrap/node.js:*:*)
     at startExecution (internal/bootstrap/node.js:*:*)
-    at startup (internal/bootstrap/node.js:*:*)
diff --git a/test/message/eval_messages.out b/test/message/eval_messages.out
index 6bfca9ea32..f41af4617d 100644
--- a/test/message/eval_messages.out
+++ b/test/message/eval_messages.out
@@ -11,8 +11,6 @@ SyntaxError: Strict mode code may not include a with statement
     at evalScript (internal/process/execution.js:*:*)
     at executeUserCode (internal/bootstrap/node.js:*:*)
     at startExecution (internal/bootstrap/node.js:*:*)
-    at startup (internal/bootstrap/node.js:*:*)
-    at internal/bootstrap/node.js:*:*
 42
 42
 [eval]:1
@@ -28,8 +26,6 @@ Error: hello
     at evalScript (internal/process/execution.js:*:*)
     at executeUserCode (internal/bootstrap/node.js:*:*)
     at startExecution (internal/bootstrap/node.js:*:*)
-    at startup (internal/bootstrap/node.js:*:*)
-    at internal/bootstrap/node.js:*:*
 
 [eval]:1
 throw new Error("hello")
@@ -44,8 +40,6 @@ Error: hello
     at evalScript (internal/process/execution.js:*:*)
     at executeUserCode (internal/bootstrap/node.js:*:*)
     at startExecution (internal/bootstrap/node.js:*:*)
-    at startup (internal/bootstrap/node.js:*:*)
-    at internal/bootstrap/node.js:*:*
 100
 [eval]:1
 var x = 100; y = x;
@@ -60,8 +54,6 @@ ReferenceError: y is not defined
     at evalScript (internal/process/execution.js:*:*)
     at executeUserCode (internal/bootstrap/node.js:*:*)
     at startExecution (internal/bootstrap/node.js:*:*)
-    at startup (internal/bootstrap/node.js:*:*)
-    at internal/bootstrap/node.js:*:*
 
 [eval]:1
 var ______________________________________________; throw 10
diff --git a/test/message/events_unhandled_error_nexttick.out b/test/message/events_unhandled_error_nexttick.out
index aa52367ba0..cd098b64bf 100644
--- a/test/message/events_unhandled_error_nexttick.out
+++ b/test/message/events_unhandled_error_nexttick.out
@@ -12,7 +12,6 @@ Error
     at Function.Module.runMain (internal/modules/cjs/loader.js:*:*)
     at executeUserCode (internal/bootstrap/node.js:*:*)
     at startExecution (internal/bootstrap/node.js:*:*)
-    at startup (internal/bootstrap/node.js:*:*)
 Emitted 'error' event at:
     at process.nextTick (*events_unhandled_error_nexttick.js:*:*)
     at internalTickCallback (internal/process/next_tick.js:*:*)
@@ -20,5 +19,3 @@ Emitted 'error' event at:
     at Function.Module.runMain (internal/modules/cjs/loader.js:*:*)
     at executeUserCode (internal/bootstrap/node.js:*:*)
     at startExecution (internal/bootstrap/node.js:*:*)
-    at startup (internal/bootstrap/node.js:*:*)
-    at internal/bootstrap/node.js:*:*
diff --git a/test/message/events_unhandled_error_sameline.out b/test/message/events_unhandled_error_sameline.out
index cd2b761203..678a9ae4b1 100644
--- a/test/message/events_unhandled_error_sameline.out
+++ b/test/message/events_unhandled_error_sameline.out
@@ -12,9 +12,8 @@ Error
     at Function.Module.runMain (internal/modules/cjs/loader.js:*:*)
     at executeUserCode (internal/bootstrap/node.js:*:*)
     at startExecution (internal/bootstrap/node.js:*:*)
-    at startup (internal/bootstrap/node.js:*:*)
 Emitted 'error' event at:
     at Object.<anonymous> (*events_unhandled_error_sameline.js:*:*)
     at Module._compile (internal/modules/cjs/loader.js:*:*)
     [... lines matching original stack trace ...]
-    at startup (internal/bootstrap/node.js:*:*)
+    at startExecution (internal/bootstrap/node.js:*:*)
diff --git a/test/message/nexttick_throw.out b/test/message/nexttick_throw.out
index 1fee9075fe..6a4d7ed2da 100644
--- a/test/message/nexttick_throw.out
+++ b/test/message/nexttick_throw.out
@@ -9,5 +9,3 @@ ReferenceError: undefined_reference_error_maker is not defined
     at Function.Module.runMain (internal/modules/cjs/loader.js:*:*)
     at executeUserCode (internal/bootstrap/node.js:*:*)
     at startExecution (internal/bootstrap/node.js:*:*)
-    at startup (internal/bootstrap/node.js:*:*)
-    at internal/bootstrap/node.js:*:*
diff --git a/test/message/unhandled_promise_trace_warnings.out b/test/message/unhandled_promise_trace_warnings.out
index 0b2ef99941..1f88a136a9 100644
--- a/test/message/unhandled_promise_trace_warnings.out
+++ b/test/message/unhandled_promise_trace_warnings.out
@@ -15,9 +15,6 @@
     at *
     at *
     at *
-    at *
-    at *
-    at *
 (node:*) Error: This was rejected
     at * (*test*message*unhandled_promise_trace_warnings.js:*)
     at *
@@ -28,7 +25,6 @@
     at *
     at *
     at *
-    at *
 (node:*) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
     at *
     at *
@@ -38,8 +34,6 @@
     at *
     at *
     at *
-    at *
-    at *
 (node:*) PromiseRejectionHandledWarning: Promise rejection was handled asynchronously (rejection id: 1)
     at handledRejection (internal/process/promises.js:*)
     at promiseRejectHandler (internal/process/promises.js:*)
diff --git a/test/message/util_inspect_error.out b/test/message/util_inspect_error.out
index 408a3c8baf..406d8112ce 100644
--- a/test/message/util_inspect_error.out
+++ b/test/message/util_inspect_error.out
@@ -10,7 +10,6 @@
        at *
        at *
        at *
-       at *
   nested:
    { err:
       Error: foo
@@ -23,7 +22,6 @@
           at *
           at *
           at *
-          at *
           at * } }
 {
   err: Error: foo
@@ -36,7 +34,6 @@
       at *
       at *
       at *
-      at *
       at *,
   nested: {
     err: Error: foo
@@ -50,7 +47,6 @@
         at *
         at *
         at *
-        at *
   }
 }
 { Error: foo
@@ -64,5 +60,4 @@ bar
     at *
     at *
     at *
-    at *
   foo: 'bar' }