diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2018-11-27 01:50:41 +0800 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2018-12-04 05:54:49 +0800 |
| commit | edcb9500902437a7edf912b27f259c173ce14767 (patch) | |
| tree | c6325da716f8004c8e5a0954a0a6466c4f745753 /test/message | |
| parent | fa19ce92339edb0d741bfe1855ac39d4bc80e1d2 (diff) | |
| download | android-node-v8-edcb9500902437a7edf912b27f259c173ce14767.tar.gz android-node-v8-edcb9500902437a7edf912b27f259c173ce14767.tar.bz2 android-node-v8-edcb9500902437a7edf912b27f259c173ce14767.zip | |
src: use NativeModuleLoader to compile all the bootstrappers
This patch moves all the bootstrapper compilation to use
NativeModuleLoader::CompileAndCall(). With this we no longer
need to mess with the error decoration and handling any more -
there is no point in handling the JS error occurred during bootstrapping
by ourselves, we should just crash or let the VM handle it.
PR-URL: https://github.com/nodejs/node/pull/24775
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'test/message')
| -rw-r--r-- | test/message/eval_messages.out | 8 | ||||
| -rw-r--r-- | test/message/events_unhandled_error_nexttick.out | 2 | ||||
| -rw-r--r-- | test/message/nexttick_throw.out | 2 |
3 files changed, 6 insertions, 6 deletions
diff --git a/test/message/eval_messages.out b/test/message/eval_messages.out index c26c63d2b0..dfa8ec0f7d 100644 --- a/test/message/eval_messages.out +++ b/test/message/eval_messages.out @@ -12,7 +12,7 @@ SyntaxError: Strict mode code may not include a with statement at executeUserCode (internal/bootstrap/node.js:*:*) at startExecution (internal/bootstrap/node.js:*:*) at startup (internal/bootstrap/node.js:*:*) - at bootstrapNodeJSCore (internal/bootstrap/node.js:*:*) + at internal/bootstrap/node.js:*:* 42 42 [eval]:1 @@ -29,7 +29,7 @@ Error: hello at executeUserCode (internal/bootstrap/node.js:*:*) at startExecution (internal/bootstrap/node.js:*:*) at startup (internal/bootstrap/node.js:*:*) - at bootstrapNodeJSCore (internal/bootstrap/node.js:*:*) + at internal/bootstrap/node.js:*:* [eval]:1 throw new Error("hello") @@ -45,7 +45,7 @@ Error: hello at executeUserCode (internal/bootstrap/node.js:*:*) at startExecution (internal/bootstrap/node.js:*:*) at startup (internal/bootstrap/node.js:*:*) - at bootstrapNodeJSCore (internal/bootstrap/node.js:*:*) + at internal/bootstrap/node.js:*:* 100 [eval]:1 var x = 100; y = x; @@ -61,7 +61,7 @@ ReferenceError: y is not defined at executeUserCode (internal/bootstrap/node.js:*:*) at startExecution (internal/bootstrap/node.js:*:*) at startup (internal/bootstrap/node.js:*:*) - at bootstrapNodeJSCore (internal/bootstrap/node.js:*:*) + at internal/bootstrap/node.js:*:* [eval]:1 var ______________________________________________; throw 10 diff --git a/test/message/events_unhandled_error_nexttick.out b/test/message/events_unhandled_error_nexttick.out index d043839fe2..1c0ed6df93 100644 --- a/test/message/events_unhandled_error_nexttick.out +++ b/test/message/events_unhandled_error_nexttick.out @@ -21,4 +21,4 @@ Emitted 'error' event at: at executeUserCode (internal/bootstrap/node.js:*:*) at startExecution (internal/bootstrap/node.js:*:*) at startup (internal/bootstrap/node.js:*:*) - at bootstrapNodeJSCore (internal/bootstrap/node.js:*:*) + at internal/bootstrap/node.js:*:* diff --git a/test/message/nexttick_throw.out b/test/message/nexttick_throw.out index 5f3c85f874..2bf69e8146 100644 --- a/test/message/nexttick_throw.out +++ b/test/message/nexttick_throw.out @@ -10,4 +10,4 @@ ReferenceError: undefined_reference_error_maker is not defined at executeUserCode (internal/bootstrap/node.js:*:*) at startExecution (internal/bootstrap/node.js:*:*) at startup (internal/bootstrap/node.js:*:*) - at bootstrapNodeJSCore (internal/bootstrap/node.js:*:*) + at internal/bootstrap/node.js:*:* |