diff options
author | Joyee Cheung <joyeec9h3@gmail.com> | 2018-12-23 08:45:07 +0800 |
---|---|---|
committer | Joyee Cheung <joyeec9h3@gmail.com> | 2019-01-06 10:28:47 +0800 |
commit | d18b0a01320e392e48f0c475effd8d4db2bb71a8 (patch) | |
tree | 91801c7d10b4adc09fe3dbc93cd1c962a7938533 /test/message | |
parent | bf566718b29a6fae8cef8d0fecd7e77948726d5a (diff) | |
download | android-node-v8-d18b0a01320e392e48f0c475effd8d4db2bb71a8.tar.gz android-node-v8-d18b0a01320e392e48f0c475effd8d4db2bb71a8.tar.bz2 android-node-v8-d18b0a01320e392e48f0c475effd8d4db2bb71a8.zip |
process: make tick callback and promise rejection callback more robust
- Rename `internalTickCallback` to `processTicksAndRejections`, make
sure it does not get called if it's not set in C++.
- Rename `emitPromiseRejectionWarnings` to `processPromiseRejections`
since it also emit events that are not warnings.
- Sets `SetPromiseRejectCallback` in the `Environment` constructor
to make sure it only gets called once per-isolate, and make
sure it does not get called if it's not set in C++.
- Wrap promise rejection callback initialization into
`listenForRejections()`.
- Add comments.
PR-URL: https://github.com/nodejs/node/pull/25200
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/message')
-rw-r--r-- | test/message/events_unhandled_error_nexttick.out | 2 | ||||
-rw-r--r-- | test/message/nexttick_throw.out | 2 | ||||
-rw-r--r-- | test/message/stdin_messages.out | 8 |
3 files changed, 6 insertions, 6 deletions
diff --git a/test/message/events_unhandled_error_nexttick.out b/test/message/events_unhandled_error_nexttick.out index cd098b64bf..e661b32d8f 100644 --- a/test/message/events_unhandled_error_nexttick.out +++ b/test/message/events_unhandled_error_nexttick.out @@ -14,7 +14,7 @@ Error at startExecution (internal/bootstrap/node.js:*:*) Emitted 'error' event at: at process.nextTick (*events_unhandled_error_nexttick.js:*:*) - at internalTickCallback (internal/process/next_tick.js:*:*) + at processTicksAndRejections (internal/process/next_tick.js:*:*) at process.runNextTicks [as _tickCallback] (internal/process/next_tick.js:*:*) at Function.Module.runMain (internal/modules/cjs/loader.js:*:*) at executeUserCode (internal/bootstrap/node.js:*:*) diff --git a/test/message/nexttick_throw.out b/test/message/nexttick_throw.out index 6a4d7ed2da..a2169b2f05 100644 --- a/test/message/nexttick_throw.out +++ b/test/message/nexttick_throw.out @@ -4,7 +4,7 @@ ^ ReferenceError: undefined_reference_error_maker is not defined at *test*message*nexttick_throw.js:*:* - at internalTickCallback (internal/process/next_tick.js:*:*) + at processTicksAndRejections (internal/process/next_tick.js:*:*) at process.runNextTicks [as _tickCallback] (internal/process/next_tick.js:*:*) at Function.Module.runMain (internal/modules/cjs/loader.js:*:*) at executeUserCode (internal/bootstrap/node.js:*:*) diff --git a/test/message/stdin_messages.out b/test/message/stdin_messages.out index ac1a4df028..2bf935d7cb 100644 --- a/test/message/stdin_messages.out +++ b/test/message/stdin_messages.out @@ -12,7 +12,7 @@ SyntaxError: Strict mode code may not include a with statement at Socket.process.stdin.on (internal/bootstrap/node.js:*:*) at Socket.emit (events.js:*:*) at endReadableNT (_stream_readable.js:*:*) - at process.internalTickCallback (internal/process/next_tick.js:*:*) + at processTicksAndRejections (internal/process/next_tick.js:*:*) 42 42 [stdin]:1 @@ -29,7 +29,7 @@ Error: hello at Socket.process.stdin.on (internal/bootstrap/node.js:*:*) at Socket.emit (events.js:*:*) at endReadableNT (_stream_readable.js:*:*) - at process.internalTickCallback (internal/process/next_tick.js:*:*) + at processTicksAndRejections (internal/process/next_tick.js:*:*) [stdin]:1 throw new Error("hello") ^ @@ -44,7 +44,7 @@ Error: hello at Socket.process.stdin.on (internal/bootstrap/node.js:*:*) at Socket.emit (events.js:*:*) at endReadableNT (_stream_readable.js:*:*) - at process.internalTickCallback (internal/process/next_tick.js:*:*) + at processTicksAndRejections (internal/process/next_tick.js:*:*) 100 [stdin]:1 var x = 100; y = x; @@ -60,7 +60,7 @@ ReferenceError: y is not defined at Socket.process.stdin.on (internal/bootstrap/node.js:*:*) at Socket.emit (events.js:*:*) at endReadableNT (_stream_readable.js:*:*) - at process.internalTickCallback (internal/process/next_tick.js:*:*) + at processTicksAndRejections (internal/process/next_tick.js:*:*) [stdin]:1 var ______________________________________________; throw 10 |