diff options
| author | Anna Henningsen <anna@addaleax.net> | 2017-11-29 20:55:43 +0100 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2017-12-05 23:49:36 +0100 |
| commit | b73e66e94918aa89643b982cd3164100d02ec997 (patch) | |
| tree | e23a4188d6330d7ea7bd34e9c04689c6f032cc5c /test/message/stdin_messages.out | |
| parent | aeddc3676bc9afe940106d34f30523f27b4cb44f (diff) | |
| download | android-node-v8-b73e66e94918aa89643b982cd3164100d02ec997.tar.gz android-node-v8-b73e66e94918aa89643b982cd3164100d02ec997.tar.bz2 android-node-v8-b73e66e94918aa89643b982cd3164100d02ec997.zip | |
vm: never abort on caught syntax error
Keep track of C++ `TryCatch` state to avoid aborting when
an exception is thrown inside one, and re-throw in JS
to make sure the exception is being picked up a second time by
a second uncaught exception handler, if necessary.
Add a bit of a hack to `AppendExceptionLine` to avoid overriding
the line responsible for re-throwing the exception.
PR-URL: https://github.com/nodejs/node/pull/17394
Fixes: https://github.com/nodejs/node/issues/13258
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/message/stdin_messages.out')
| -rw-r--r-- | test/message/stdin_messages.out | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/test/message/stdin_messages.out b/test/message/stdin_messages.out index d934523a72..d2192050dd 100644 --- a/test/message/stdin_messages.out +++ b/test/message/stdin_messages.out @@ -3,6 +3,7 @@ with(this){__filename} ^^^^ SyntaxError: Strict mode code may not include a with statement + at new Script (vm.js:*) at createScript (vm.js:*) at Object.runInThisContext (vm.js:*) at Object.<anonymous> ([stdin]-wrapper:*:*) @@ -20,7 +21,7 @@ throw new Error("hello") Error: hello at [stdin]:1:7 - at ContextifyScript.Script.runInThisContext (vm.js:*) + at Script.runInThisContext (vm.js:*) at Object.runInThisContext (vm.js:*) at Object.<anonymous> ([stdin]-wrapper:*:*) at Module._compile (module.js:*:*) @@ -35,7 +36,7 @@ throw new Error("hello") Error: hello at [stdin]:1:* - at ContextifyScript.Script.runInThisContext (vm.js:*) + at Script.runInThisContext (vm.js:*) at Object.runInThisContext (vm.js:*) at Object.<anonymous> ([stdin]-wrapper:*:*) at Module._compile (module.js:*:*) @@ -51,7 +52,7 @@ var x = 100; y = x; ReferenceError: y is not defined at [stdin]:1:16 - at ContextifyScript.Script.runInThisContext (vm.js:*) + at Script.runInThisContext (vm.js:*) at Object.runInThisContext (vm.js:*) at Object.<anonymous> ([stdin]-wrapper:*:*) at Module._compile (module.js:*:*) |