diff options
author | Rich Trott <rtrott@gmail.com> | 2019-06-27 16:36:47 -0700 |
---|---|---|
committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-07-02 06:49:40 +0200 |
commit | e008ca8b93af0eb5e360ee1244680c914a795344 (patch) | |
tree | ce8c20414647b364f8f5b5c9bfb506f8b750fb34 /test/known_issues | |
parent | 3c9c89df128cb4c25d9161a1789d44442e99c6fb (diff) | |
download | android-node-v8-e008ca8b93af0eb5e360ee1244680c914a795344.tar.gz android-node-v8-e008ca8b93af0eb5e360ee1244680c914a795344.tar.bz2 android-node-v8-e008ca8b93af0eb5e360ee1244680c914a795344.zip |
test: fix flaky test-vm-timeout-escape-nexttick
PR-URL: https://github.com/nodejs/node/pull/28461
Fixes: https://github.com/nodejs/node/issues/24120
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/known_issues')
-rw-r--r-- | test/known_issues/known_issues.status | 2 | ||||
-rw-r--r-- | test/known_issues/test-vm-timeout-escape-nexttick.js | 30 |
2 files changed, 17 insertions, 15 deletions
diff --git a/test/known_issues/known_issues.status b/test/known_issues/known_issues.status index fbc4534cf6..fdf2d86bcd 100644 --- a/test/known_issues/known_issues.status +++ b/test/known_issues/known_issues.status @@ -22,5 +22,3 @@ test-vm-timeout-escape-promise: PASS,FLAKY [$system==aix] [$arch==arm] -# https://github.com/nodejs/node/issues/24120 -test-vm-timeout-escape-nexttick: PASS,FLAKY diff --git a/test/known_issues/test-vm-timeout-escape-nexttick.js b/test/known_issues/test-vm-timeout-escape-nexttick.js index 40937c96d9..c6967cd742 100644 --- a/test/known_issues/test-vm-timeout-escape-nexttick.js +++ b/test/known_issues/test-vm-timeout-escape-nexttick.js @@ -27,16 +27,20 @@ function loop() { } } -assert.throws(() => { - vm.runInNewContext( - 'nextTick(loop); loop();', - { - hrtime, - nextTick, - loop - }, - { timeout: common.platformTimeout(10) } - ); -}, { - code: 'ERR_SCRIPT_EXECUTION_TIMEOUT' -}); +// The bug won't happen 100% reliably so run the test a small number of times to +// make sure we catch it if the bug exists. +for (let i = 0; i < 4; i++) { + assert.throws(() => { + vm.runInNewContext( + 'nextTick(loop); loop();', + { + hrtime, + nextTick, + loop + }, + { timeout: common.platformTimeout(10) } + ); + }, { + code: 'ERR_SCRIPT_EXECUTION_TIMEOUT' + }); +} |