summaryrefslogtreecommitdiff
path: root/test/known_issues
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2019-01-14 14:20:07 -0800
committerRich Trott <rtrott@gmail.com>2019-01-15 05:59:43 -0800
commit27f6d04dcf092c23d00d19eacf13e5c751ea9c5f (patch)
tree44b6cb695ba25466bb5e6089068473e895ab99f8 /test/known_issues
parentf216d5bbb1595f2fbed29517ba87b80e8c02f3c0 (diff)
downloadandroid-node-v8-27f6d04dcf092c23d00d19eacf13e5c751ea9c5f.tar.gz
android-node-v8-27f6d04dcf092c23d00d19eacf13e5c751ea9c5f.tar.bz2
android-node-v8-27f6d04dcf092c23d00d19eacf13e5c751ea9c5f.zip
test: improve known_issues/test-vm-timeout-escape-queuemicrotask
Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate CI failures on ubuntu1604-arm64. Failures are due to a race condition. Use `common.platformTimeout()` to help, adjust timeout to make sure `queueMicrotasks()` has a chance to run, and improve error message. PR-URL: https://github.com/nodejs/node/pull/25503 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com>
Diffstat (limited to 'test/known_issues')
-rw-r--r--test/known_issues/test-vm-timeout-escape-queuemicrotask.js11
1 files changed, 7 insertions, 4 deletions
diff --git a/test/known_issues/test-vm-timeout-escape-queuemicrotask.js b/test/known_issues/test-vm-timeout-escape-queuemicrotask.js
index 1ed327f779..df0531bae1 100644
--- a/test/known_issues/test-vm-timeout-escape-queuemicrotask.js
+++ b/test/known_issues/test-vm-timeout-escape-queuemicrotask.js
@@ -12,14 +12,17 @@ const NS_PER_MS = 1000000n;
const hrtime = process.hrtime.bigint;
+const loopDuration = common.platformTimeout(100n);
+const timeout = common.platformTimeout(10);
+
function loop() {
const start = hrtime();
while (1) {
const current = hrtime();
const span = (current - start) / NS_PER_MS;
- if (span >= 100n) {
+ if (span >= loopDuration) {
throw new Error(
- `escaped timeout at ${span} milliseconds!`);
+ `escaped ${timeout}ms timeout at ${span}ms`);
}
}
}
@@ -32,9 +35,9 @@ assert.throws(() => {
queueMicrotask,
loop
},
- { timeout: common.platformTimeout(5) }
+ { timeout }
);
}, {
code: 'ERR_SCRIPT_EXECUTION_TIMEOUT',
- message: 'Script execution timed out after 5ms'
+ message: `Script execution timed out after ${timeout}ms`
});