summaryrefslogtreecommitdiff
path: root/test/js-native-api/test_error
diff options
context:
space:
mode:
authorRuben Bridgewater <ruben@bridgewater.de>2019-03-18 15:43:11 +0100
committerRuben Bridgewater <ruben@bridgewater.de>2019-03-23 02:55:57 +0100
commitf0f26cedccdb8e5d891bff2949651ea8c3a839c1 (patch)
tree8a05b335b407f283a8df1d8069d6b1d81266c090 /test/js-native-api/test_error
parente96e3f9eb0610168b0b06977664c0e713571b066 (diff)
downloadandroid-node-v8-f0f26cedccdb8e5d891bff2949651ea8c3a839c1.tar.gz
android-node-v8-f0f26cedccdb8e5d891bff2949651ea8c3a839c1.tar.bz2
android-node-v8-f0f26cedccdb8e5d891bff2949651ea8c3a839c1.zip
n-api: remove code from error name
This is a first step to align the n-api errors towards errors created in JS. The stack still has to be updated to add the error code. PR-URL: https://github.com/nodejs/node/pull/26738 Fixes: https://github.com/nodejs/node/issues/26669 Fixes: https://github.com/nodejs/node/issues/20253 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaƫl Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'test/js-native-api/test_error')
-rw-r--r--test/js-native-api/test_error/test.js6
1 files changed, 3 insertions, 3 deletions
diff --git a/test/js-native-api/test_error/test.js b/test/js-native-api/test_error/test.js
index d4b1d8a971..e7e0ded476 100644
--- a/test/js-native-api/test_error/test.js
+++ b/test/js-native-api/test_error/test.js
@@ -118,18 +118,18 @@ error = test_error.createErrorCode();
assert.ok(error instanceof Error, 'expected error to be an instance of Error');
assert.strictEqual(error.code, 'ERR_TEST_CODE');
assert.strictEqual(error.message, 'Error [error]');
-assert.strictEqual(error.name, 'Error [ERR_TEST_CODE]');
+assert.strictEqual(error.name, 'Error');
error = test_error.createRangeErrorCode();
assert.ok(error instanceof RangeError,
'expected error to be an instance of RangeError');
assert.strictEqual(error.message, 'RangeError [range error]');
assert.strictEqual(error.code, 'ERR_TEST_CODE');
-assert.strictEqual(error.name, 'RangeError [ERR_TEST_CODE]');
+assert.strictEqual(error.name, 'RangeError');
error = test_error.createTypeErrorCode();
assert.ok(error instanceof TypeError,
'expected error to be an instance of TypeError');
assert.strictEqual(error.message, 'TypeError [type error]');
assert.strictEqual(error.code, 'ERR_TEST_CODE');
-assert.strictEqual(error.name, 'TypeError [ERR_TEST_CODE]');
+assert.strictEqual(error.name, 'TypeError');