diff options
| author | Michaël Zasso <targos@protonmail.com> | 2018-07-17 08:23:49 +0200 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2018-07-19 08:47:28 +0200 |
| commit | df08779e0dfa82ceb69e129ae0548e97352aaddf (patch) | |
| tree | a589930afbeaf5481f3fe614eeee05fc04b7ec35 /test/internet/test-dns.js | |
| parent | 373aae1f86c1d061123e3aec28980aa2e7d1ebd4 (diff) | |
| download | android-node-v8-df08779e0dfa82ceb69e129ae0548e97352aaddf.tar.gz android-node-v8-df08779e0dfa82ceb69e129ae0548e97352aaddf.tar.bz2 android-node-v8-df08779e0dfa82ceb69e129ae0548e97352aaddf.zip | |
test: make crashOnUnhandleRejection opt-out
This commit removes `common.crashOnUnhandledRejection()` and adds
`common.disableCrashOnUnhandledRejection()`.
To reduce the risk of mistakes and make writing tests that involve
promises simpler, always install the unhandledRejection hook in tests
and provide a way to disable it for the rare cases where it's needed.
PR-URL: https://github.com/nodejs/node/pull/21849
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'test/internet/test-dns.js')
| -rw-r--r-- | test/internet/test-dns.js | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/test/internet/test-dns.js b/test/internet/test-dns.js index 593d621e82..4608713927 100644 --- a/test/internet/test-dns.js +++ b/test/internet/test-dns.js @@ -30,8 +30,6 @@ const isIPv6 = net.isIPv6; const util = require('util'); const dnsPromises = dns.promises; -common.crashOnUnhandledRejection(); - let expected = 0; let completed = 0; let running = false; |