summaryrefslogtreecommitdiff
path: root/test/internet/test-dns.js
diff options
context:
space:
mode:
authorRuben Bridgewater <ruben@bridgewater.de>2018-02-10 02:33:08 +0100
committerRuben Bridgewater <ruben@bridgewater.de>2018-02-16 16:54:07 +0100
commit644fdd60d4be49ffa66d0bda1702c4459f607635 (patch)
tree70da98bc22a5a6c5bd0063e25d6eb729125706bf /test/internet/test-dns.js
parentcaee112e52b64f4bc1118c4a5fa5ad7b4211efea (diff)
downloadandroid-node-v8-644fdd60d4be49ffa66d0bda1702c4459f607635.tar.gz
android-node-v8-644fdd60d4be49ffa66d0bda1702c4459f607635.tar.bz2
android-node-v8-644fdd60d4be49ffa66d0bda1702c4459f607635.zip
test: minor refactoring
Add punctuation and comments about code that should not throw. Also remove a obsolete test and refactor some tests. PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'test/internet/test-dns.js')
-rw-r--r--test/internet/test-dns.js5
1 files changed, 1 insertions, 4 deletions
diff --git a/test/internet/test-dns.js b/test/internet/test-dns.js
index dadf14c0be..f1b7b4ff05 100644
--- a/test/internet/test-dns.js
+++ b/test/internet/test-dns.js
@@ -579,11 +579,8 @@ process.on('exit', function() {
assert.ok(getaddrinfoCallbackCalled);
});
-
+// Should not throw.
dns.lookup(addresses.INET6_HOST, 6, common.mustCall());
-
dns.lookup(addresses.INET_HOST, {}, common.mustCall());
-
dns.lookupService('0.0.0.0', '0', common.mustCall());
-
dns.lookupService('0.0.0.0', 0, common.mustCall());