diff options
author | Rich Trott <rtrott@gmail.com> | 2018-10-10 11:24:51 -0700 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2018-10-12 13:48:42 -0700 |
commit | f897843359a1f1b8dc9839105b84dcc50a15e1f6 (patch) | |
tree | a188059551af314ed5c279b17edeb10f9c3762bf /test/fixtures | |
parent | bcbb9370ddaa223110fcd8584e41336b791e7e7f (diff) | |
download | android-node-v8-f897843359a1f1b8dc9839105b84dcc50a15e1f6.tar.gz android-node-v8-f897843359a1f1b8dc9839105b84dcc50a15e1f6.tar.bz2 android-node-v8-f897843359a1f1b8dc9839105b84dcc50a15e1f6.zip |
test: refactor common.ddCommand()
* Remove different paths for Windows and POSIX.
* Remove fixtures file. Simply run the command immediately/directly.
* Since it is never called with more than one value for kilobytes,
eliminate that argument.
* Update/simplify tests that use this function. (They no longer need to
use child_process to run the command.)
* Update documentation.
PR-URL: https://github.com/nodejs/node/pull/23411
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Diffstat (limited to 'test/fixtures')
-rw-r--r-- | test/fixtures/create-file.js | 29 |
1 files changed, 0 insertions, 29 deletions
diff --git a/test/fixtures/create-file.js b/test/fixtures/create-file.js deleted file mode 100644 index ec0d8243d3..0000000000 --- a/test/fixtures/create-file.js +++ /dev/null @@ -1,29 +0,0 @@ -// Copyright Joyent, Inc. and other Node contributors. -// -// Permission is hereby granted, free of charge, to any person obtaining a -// copy of this software and associated documentation files (the -// "Software"), to deal in the Software without restriction, including -// without limitation the rights to use, copy, modify, merge, publish, -// distribute, sublicense, and/or sell copies of the Software, and to permit -// persons to whom the Software is furnished to do so, subject to the -// following conditions: -// -// The above copyright notice and this permission notice shall be included -// in all copies or substantial portions of the Software. -// -// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS -// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF -// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN -// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, -// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR -// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE -// USE OR OTHER DEALINGS IN THE SOFTWARE. - -const fs = require('fs'); - -var file_name = process.argv[2]; -var file_size = parseInt(process.argv[3]); - -var fd = fs.openSync(file_name, 'w'); -fs.ftruncateSync(fd, file_size); -fs.closeSync(fd); |