diff options
| author | Rich Trott <rtrott@gmail.com> | 2019-06-11 13:55:26 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-06-13 23:01:40 -0700 |
| commit | 4928c2f3b121b54169fd5d51872c673df9c27cae (patch) | |
| tree | eb2fe8eb1e9c1a0aa40a050eb256e7ee61fe4b46 /test/common | |
| parent | 06c818a464b58831ed7be37e5a8412fc9a9b6eae (diff) | |
| download | android-node-v8-4928c2f3b121b54169fd5d51872c673df9c27cae.tar.gz android-node-v8-4928c2f3b121b54169fd5d51872c673df9c27cae.tar.bz2 android-node-v8-4928c2f3b121b54169fd5d51872c673df9c27cae.zip | |
test: remove unused `output` argument for `getFrames()`
PR-URL: https://github.com/nodejs/node/pull/28183
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/common')
| -rw-r--r-- | test/common/README.md | 3 | ||||
| -rw-r--r-- | test/common/cpu-prof.js | 4 |
2 files changed, 3 insertions, 4 deletions
diff --git a/test/common/README.md b/test/common/README.md index a60a60ce20..1f47baf7a8 100644 --- a/test/common/README.md +++ b/test/common/README.md @@ -450,9 +450,8 @@ Windows and `30` elsewhere. Returns an array of all `.cpuprofile` files found in `dir`. -### getFrames(output, file, suffix) +### getFrames(file, suffix) -* `output` Unused. * `file` {string} Path to a `.cpuprofile` file. * `suffix` {string} Suffix of the URL of call frames to retrieve. * returns { frames: [<Object>], nodes: [<Object>] } diff --git a/test/common/cpu-prof.js b/test/common/cpu-prof.js index 78e746082b..8e8bd42275 100644 --- a/test/common/cpu-prof.js +++ b/test/common/cpu-prof.js @@ -14,7 +14,7 @@ function getCpuProfiles(dir) { .map((file) => path.join(dir, file)); } -function getFrames(output, file, suffix) { +function getFrames(file, suffix) { const data = fs.readFileSync(file, 'utf8'); const profile = JSON.parse(data); const frames = profile.nodes.filter((i) => { @@ -25,7 +25,7 @@ function getFrames(output, file, suffix) { } function verifyFrames(output, file, suffix) { - const { frames, nodes } = getFrames(output, file, suffix); + const { frames, nodes } = getFrames(file, suffix); if (frames.length === 0) { // Show native debug output and the profile for debugging. console.log(output.stderr.toString()); |