diff options
| author | killagu <killa123@126.com> | 2018-02-11 11:50:31 +0800 |
|---|---|---|
| committer | Matheus Marchini <matheus@sthima.com> | 2018-02-17 10:06:53 -0200 |
| commit | 38f04d4da179dd3610ee07c2441601cdb2436a6a (patch) | |
| tree | d0955675fecc0a401eaa01fdef66a0fd31506c02 /test/common | |
| parent | 513d9397202b46fb10da41d88ddb747417f8b870 (diff) | |
| download | android-node-v8-38f04d4da179dd3610ee07c2441601cdb2436a6a.tar.gz android-node-v8-38f04d4da179dd3610ee07c2441601cdb2436a6a.tar.bz2 android-node-v8-38f04d4da179dd3610ee07c2441601cdb2436a6a.zip | |
tools, test: fix prof polyfill readline
`node --prof foo.js` may not print the full profile log file, leaving
the last line broken (for example `tick,`. When that happens, `readline`
will be stuck in an infinite loop. This patch fixes it.
Also introduced `common.isCPPSymbolsNotMapped` to avoid duplicated code
on tick-processor tests.
PR-URL: https://github.com/nodejs/node/pull/18641
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test/common')
| -rw-r--r-- | test/common/README.md | 5 | ||||
| -rw-r--r-- | test/common/index.js | 5 |
2 files changed, 10 insertions, 0 deletions
diff --git a/test/common/README.md b/test/common/README.md index 18f0e4915b..e0a66e9da0 100644 --- a/test/common/README.md +++ b/test/common/README.md @@ -243,6 +243,11 @@ Platform check for Windows. Platform check for Windows 32-bit on Windows 64-bit. +### isCPPSymbolsNotMapped +* [<Boolean>] + +Platform check for C++ symbols are mapped or not. + ### leakedGlobals() * return [<Array>] diff --git a/test/common/index.js b/test/common/index.js index a38b985208..b24d2158e7 100644 --- a/test/common/index.js +++ b/test/common/index.js @@ -803,3 +803,8 @@ exports.hijackStdout = hijackStdWritable.bind(null, 'stdout'); exports.hijackStderr = hijackStdWritable.bind(null, 'stderr'); exports.restoreStdout = restoreWritable.bind(null, 'stdout'); exports.restoreStderr = restoreWritable.bind(null, 'stderr'); +exports.isCPPSymbolsNotMapped = exports.isWindows || + exports.isSunOS || + exports.isAIX || + exports.isLinuxPPCBE || + exports.isFreeBSD; |