diff options
| author | Rich Trott <rtrott@gmail.com> | 2019-10-16 09:39:14 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-10-18 11:32:04 -0700 |
| commit | fa2ba05bcd11b9485e39bcfee62589a640817317 (patch) | |
| tree | 33dcefc969a357ed6da57da14ef75c8bb4b61def /test/common/index.js | |
| parent | ce72cd779a13653163ffea06bd7f56d12903f4ce (diff) | |
| download | android-node-v8-fa2ba05bcd11b9485e39bcfee62589a640817317.tar.gz android-node-v8-fa2ba05bcd11b9485e39bcfee62589a640817317.tar.bz2 android-node-v8-fa2ba05bcd11b9485e39bcfee62589a640817317.zip | |
test: remove common.skipIfInspectorEnabled()
common.skipIfInspectorEnabled() is only used once in all of the tests.
The test is more clear (in my opinion, at least) without the abstraction
so put the check directly in the test. Additionally, it honestly looks
like an error (which is how I noticed it in the first place) and that
someone mistyped the far more common skipIfInspectorDisabled().
PR-URL: https://github.com/nodejs/node/pull/29993
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Diffstat (limited to 'test/common/index.js')
| -rw-r--r-- | test/common/index.js | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/test/common/index.js b/test/common/index.js index 00ebd283a0..98a2687222 100644 --- a/test/common/index.js +++ b/test/common/index.js @@ -651,12 +651,6 @@ function skipIfInspectorDisabled() { } } -function skipIfInspectorEnabled() { - if (process.features.inspector) { - skip('V8 inspector is enabled'); - } -} - function skipIfReportDisabled() { if (!process.config.variables.node_report) { skip('Diagnostic reporting is disabled'); @@ -789,7 +783,6 @@ module.exports = { skipIf32Bits, skipIfEslintMissing, skipIfInspectorDisabled, - skipIfInspectorEnabled, skipIfReportDisabled, skipIfWorker, |