diff options
| author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-05-14 14:30:24 +0200 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-05-19 17:55:54 +0200 |
| commit | cbee12c70160ec4d123194668451c908faf446bd (patch) | |
| tree | fdbcca95384fda6eecccbd4acfd8a2acea0518db /test/common/index.js | |
| parent | 8254e389f53703f33951c56e5e0ec11a2d51f661 (diff) | |
| download | android-node-v8-cbee12c70160ec4d123194668451c908faf446bd.tar.gz android-node-v8-cbee12c70160ec4d123194668451c908faf446bd.tar.bz2 android-node-v8-cbee12c70160ec4d123194668451c908faf446bd.zip | |
test: remove untested knownGlobals
These values are all non-enumerable and will never be checked.
By removing them, we make sure they will not become enumerable
unnoticed.
PR-URL: https://github.com/nodejs/node/pull/20717
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'test/common/index.js')
| -rw-r--r-- | test/common/index.js | 25 |
1 files changed, 0 insertions, 25 deletions
diff --git a/test/common/index.js b/test/common/index.js index 07c0992d65..743bf15fb8 100644 --- a/test/common/index.js +++ b/test/common/index.js @@ -310,8 +310,6 @@ let knownGlobals = [ clearImmediate, clearInterval, clearTimeout, - console, - constructor, // Enumerable in V8 3.21. global, process, setImmediate, @@ -341,29 +339,6 @@ if (global.COUNTER_NET_SERVER_CONNECTION) { knownGlobals.push(COUNTER_HTTP_CLIENT_RESPONSE); } -if (global.ArrayBuffer) { - knownGlobals.push(ArrayBuffer); - knownGlobals.push(Int8Array); - knownGlobals.push(Uint8Array); - knownGlobals.push(Uint8ClampedArray); - knownGlobals.push(Int16Array); - knownGlobals.push(Uint16Array); - knownGlobals.push(Int32Array); - knownGlobals.push(Uint32Array); - knownGlobals.push(Float32Array); - knownGlobals.push(Float64Array); - knownGlobals.push(DataView); -} - -// Harmony features. -if (global.Proxy) { - knownGlobals.push(Proxy); -} - -if (global.Symbol) { - knownGlobals.push(Symbol); -} - if (process.env.NODE_TEST_KNOWN_GLOBALS) { const knownFromEnv = process.env.NODE_TEST_KNOWN_GLOBALS.split(','); allowGlobals(...knownFromEnv); |