diff options
| author | Rich Trott <rtrott@gmail.com> | 2017-10-21 11:10:42 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2017-10-21 12:04:59 -0700 |
| commit | 8e268c70dd5b5d98658544a5d46cd8d8d4b17481 (patch) | |
| tree | 39a33ee60a7f1787ef3f77819e99591dbbe65063 /test/common/index.js | |
| parent | fe4675b301f0e3e26dcb88ef9f68fe35403330a0 (diff) | |
| download | android-node-v8-8e268c70dd5b5d98658544a5d46cd8d8d4b17481.tar.gz android-node-v8-8e268c70dd5b5d98658544a5d46cd8d8d4b17481.tar.bz2 android-node-v8-8e268c70dd5b5d98658544a5d46cd8d8d4b17481.zip | |
test: fix common.PIPE path bug
`common.PIPE` is returning a path name in `test` rather than in the
`tmp` directory for each test. This is causing multiple test failures in
CI. Make the path name inside the temporary directories again. This way
the pipe is removed by `common.refreshTmpDir()` on POSIX.
The bug in `common.PIPE` was introduced in
c34ae48083b44f1da7be75c8d11abc9f3aa7ab19.
PR-URL: https://github.com/nodejs/node/pull/16364
Fixes: https://github.com/nodejs/node/issues/16290
Fixes: https://github.com/nodejs/node/issues/16323
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Diffstat (limited to 'test/common/index.js')
| -rw-r--r-- | test/common/index.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/common/index.js b/test/common/index.js index 58ab88e75c..e356001e8a 100644 --- a/test/common/index.js +++ b/test/common/index.js @@ -274,7 +274,7 @@ Object.defineProperty(exports, 'hasFipsCrypto', { const localRelative = path.relative(process.cwd(), `${exports.tmpDir}/`); const pipePrefix = exports.isWindows ? '\\\\.\\pipe\\' : localRelative; const pipeName = `node-test.${process.pid}.sock`; - exports.PIPE = pipePrefix + pipeName; + exports.PIPE = path.join(pipePrefix, pipeName); } { |