diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-11-07 14:40:35 -0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-11-07 19:26:32 -0800 |
| commit | d8e06b23b047b52c96ee01f7afb436aad4610c71 (patch) | |
| tree | 78a881b28c8364c31f6556b1013bf99d476f0e57 /test/common/README.md | |
| parent | 5c596222433166a7c0274251cca1e55f3bf9560f (diff) | |
| download | android-node-v8-d8e06b23b047b52c96ee01f7afb436aad4610c71.tar.gz android-node-v8-d8e06b23b047b52c96ee01f7afb436aad4610c71.tar.bz2 android-node-v8-d8e06b23b047b52c96ee01f7afb436aad4610c71.zip | |
test: fix flaky VM timeout test on Raspberry Pi
Increase the timeouts based on platform. This required adjusting
common.platformTimeout() to deal with bigint.
Fixes: https://github.com/nodejs/node/issues/24120
PR-URL: https://github.com/nodejs/node/pull/24238
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Diffstat (limited to 'test/common/README.md')
| -rw-r--r-- | test/common/README.md | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/test/common/README.md b/test/common/README.md index afc267ba7c..f0bcced82e 100644 --- a/test/common/README.md +++ b/test/common/README.md @@ -271,10 +271,12 @@ See `common.expectWarning()` for usage. Indicates whether 'opensslCli' is supported. ### platformTimeout(ms) -* `ms` [<number>] -* return [<number>] +* `ms` [<number>|<bigint>] +* return [<number>|<bigint>] -Platform normalizes timeout. +Returns a timeout value based on detected conditions. For example, a debug build +may need extra time so the returned value will be larger than on a release +build. ### PIPE * [<string>] |