diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2018-02-09 01:22:37 +0800 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-02-10 15:58:45 +0100 |
| commit | c5c9515c1b8abea2fd98cdd1319176ea1c367764 (patch) | |
| tree | 7f28822fd5759094215e50e3f3d62da2ad937116 /test/cctest | |
| parent | df2f4ad22b27bc4cf26e1c5552d037327850bef4 (diff) | |
| download | android-node-v8-c5c9515c1b8abea2fd98cdd1319176ea1c367764.tar.gz android-node-v8-c5c9515c1b8abea2fd98cdd1319176ea1c367764.tar.bz2 android-node-v8-c5c9515c1b8abea2fd98cdd1319176ea1c367764.zip | |
fs: fix stack overflow in fs.readdirSync
Previously, fs.readdirSync calls the function returned by
env->push_values_to_array_function() in batch and check the returned
Maybe right away in C++, which can lead to assertions if the call stack
already reaches the maximum size. This patch fixes that by returning
early the call fails so the stack overflow error will be properly
thrown into JS land.
PR-URL: https://github.com/nodejs/node/pull/18647
Fixes: https://github.com/nodejs/node/issues/18645
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/cctest')
0 files changed, 0 insertions, 0 deletions