summaryrefslogtreecommitdiff
path: root/test/cctest
diff options
context:
space:
mode:
authorDaniel Bevenius <daniel.bevenius@gmail.com>2018-06-20 10:31:04 +0200
committerDaniel Bevenius <daniel.bevenius@gmail.com>2018-06-27 05:19:56 +0200
commit8326bea6c2833b653f92239725bf4a32e5f52c90 (patch)
treebd5f72ef2003b4b8b1d50999a863d3bb430d4c96 /test/cctest
parentd6f7a32570994b21c628b517b3ddc863a1f059fb (diff)
downloadandroid-node-v8-8326bea6c2833b653f92239725bf4a32e5f52c90.tar.gz
android-node-v8-8326bea6c2833b653f92239725bf4a32e5f52c90.tar.bz2
android-node-v8-8326bea6c2833b653f92239725bf4a32e5f52c90.zip
test: use aliases for smart pointers in fixture
PR-URL: https://github.com/nodejs/node/pull/21419 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'test/cctest')
-rw-r--r--test/cctest/node_test_fixture.cc4
-rw-r--r--test/cctest/node_test_fixture.h6
2 files changed, 6 insertions, 4 deletions
diff --git a/test/cctest/node_test_fixture.cc b/test/cctest/node_test_fixture.cc
index 1fe6ba477b..acc975a4cb 100644
--- a/test/cctest/node_test_fixture.cc
+++ b/test/cctest/node_test_fixture.cc
@@ -2,5 +2,5 @@
ArrayBufferUniquePtr NodeTestFixture::allocator{nullptr, nullptr};
uv_loop_t NodeTestFixture::current_loop;
-std::unique_ptr<node::NodePlatform> NodeTestFixture::platform;
-std::unique_ptr<v8::TracingController> NodeTestFixture::tracing_controller;
+NodePlatformUniquePtr NodeTestFixture::platform;
+TracingControllerUniquePtr NodeTestFixture::tracing_controller;
diff --git a/test/cctest/node_test_fixture.h b/test/cctest/node_test_fixture.h
index c9193ffffa..8cba5d99ba 100644
--- a/test/cctest/node_test_fixture.h
+++ b/test/cctest/node_test_fixture.h
@@ -55,12 +55,14 @@ struct Argv {
using ArrayBufferUniquePtr = std::unique_ptr<node::ArrayBufferAllocator,
decltype(&node::FreeArrayBufferAllocator)>;
+using TracingControllerUniquePtr = std::unique_ptr<v8::TracingController>;
+using NodePlatformUniquePtr = std::unique_ptr<node::NodePlatform>;
class NodeTestFixture : public ::testing::Test {
protected:
static ArrayBufferUniquePtr allocator;
- static std::unique_ptr<v8::TracingController> tracing_controller;
- static std::unique_ptr<node::NodePlatform> platform;
+ static TracingControllerUniquePtr tracing_controller;
+ static NodePlatformUniquePtr platform;
static uv_loop_t current_loop;
v8::Isolate* isolate_;