diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2017-07-17 06:40:19 +0200 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2017-07-29 19:24:50 +0200 |
| commit | 75bf8a9db9e6005c6b5a5beb086a9def6e1c1b76 (patch) | |
| tree | 9211c0ae03ca983275e3e4e8cfd5382253085dbe /test/cctest | |
| parent | 46d3ff2af98e67bbf583fcee1fd2551d8727a181 (diff) | |
| download | android-node-v8-75bf8a9db9e6005c6b5a5beb086a9def6e1c1b76.tar.gz android-node-v8-75bf8a9db9e6005c6b5a5beb086a9def6e1c1b76.tar.bz2 android-node-v8-75bf8a9db9e6005c6b5a5beb086a9def6e1c1b76.zip | |
test: add DISABLED_ prefix to commented out test
Commit 95ab966a742d23d7271c7b4c36fb84aa2bbece59 ("test: disable
MultipleEnvironmentsPerIsolate") commented out
MultipleEnvironmentsPerIsolate but it migth be better to disable
the test so that this gets reported and not forgotten:
YOU HAVE 1 DISABLED TEST
PR-URL: https://github.com/nodejs/node/pull/14317
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Diffstat (limited to 'test/cctest')
| -rw-r--r-- | test/cctest/test_environment.cc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/test/cctest/test_environment.cc b/test/cctest/test_environment.cc index d116b4d995..db08743261 100644 --- a/test/cctest/test_environment.cc +++ b/test/cctest/test_environment.cc @@ -85,8 +85,7 @@ TEST_F(EnvironmentTest, AtExitWithArgument) { EXPECT_EQ(arg, cb_1_arg); } -/* -TEST_F(EnvironmentTest, MultipleEnvironmentsPerIsolate) { +TEST_F(EnvironmentTest, DISABLED_MultipleEnvironmentsPerIsolate) { const v8::HandleScope handle_scope(isolate_); const Argv argv; Env env1 {handle_scope, isolate_, argv}; @@ -101,7 +100,6 @@ TEST_F(EnvironmentTest, MultipleEnvironmentsPerIsolate) { RunAtExit(*env2); EXPECT_TRUE(called_cb_2); } -*/ static void at_exit_callback1(void* arg) { called_cb_1 = true; |