diff options
| author | Mike Kaufman <mike.kaufman@microsoft.com> | 2017-09-21 10:55:09 -0700 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2017-09-24 13:35:58 -0300 |
| commit | 6faede7eb4d1568e79f03bdc4807cce598d30c47 (patch) | |
| tree | 078f4ebfd95afa58b1c8318d8102ee3c27001b02 /test/cctest | |
| parent | 3d7f7b2a0c2bb36e67ac6901bb9bd41cbd211c7a (diff) | |
| download | android-node-v8-6faede7eb4d1568e79f03bdc4807cce598d30c47.tar.gz android-node-v8-6faede7eb4d1568e79f03bdc4807cce598d30c47.tar.bz2 android-node-v8-6faede7eb4d1568e79f03bdc4807cce598d30c47.zip | |
test: fixing AliasedBuffer tests to enter Isolate
AliasedBuffer tests weren't creating an v8::Isolate::Scope, and this
had negative impact on the node-chakracore branch, where expectation
is an Isoalte has been Enter()'d before being used.
PR-URL: https://github.com/nodejs/node/pull/15536
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test/cctest')
| -rw-r--r-- | test/cctest/test_aliased_buffer.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/test/cctest/test_aliased_buffer.cc b/test/cctest/test_aliased_buffer.cc index 65b029f2a0..8dfb02c181 100644 --- a/test/cctest/test_aliased_buffer.cc +++ b/test/cctest/test_aliased_buffer.cc @@ -82,6 +82,7 @@ void ReadAndValidate(v8::Isolate* isolate, template<class NativeT, class V8T> void ReadWriteTest(v8::Isolate* isolate) { + v8::Isolate::Scope isolate_scope(isolate); v8::HandleScope handle_scope(isolate); v8::Local<v8::Context> context = v8::Context::New(isolate); v8::Context::Scope context_scope(context); @@ -114,6 +115,7 @@ void SharedBufferTest( size_t count_A, size_t count_B, size_t count_C) { + v8::Isolate::Scope isolate_scope(isolate); v8::HandleScope handle_scope(isolate); v8::Local<v8::Context> context = v8::Context::New(isolate); v8::Context::Scope context_scope(context); |