build: add node_lib_target_name to cctest deps

Currently the cctest target depend on the node_core_target_name
target. But it is the node_lib_target_name target that compiles the
sources now which means that if a source file in src is updated the
cctest executable will not be re-linked against it, but will remain
unchanged. The code will still be compiled, just not linked which
means that if you are debugging you'll not see the changes and also a
warning will be displayed about this issue.

This commit changes the cctest target to depend on node_lib_target_name.

PR-URL: https://github.com/nodejs/node/pull/18576
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Yihong Wang <yh.wang@ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

2 files changed, 22 insertions, 32 deletions

diff --git a/test/cctest/node_module_reg.cc b/test/cctest/node_module_reg.cc
deleted file mode 100644
index bd4f20bc9f..0000000000
--- a/test/cctest/node_module_reg.cc
+++ /dev/null
@@ -1,30 +0,0 @@
-// Need to create empty definition for these modules'
-// registration function for cctest. Because when
-// building cctest, the definitions for the following
-// registration functions are not included.
-void _register_cares_wrap() {}
-void _register_config() {}
-void _register_contextify() {}
-void _register_domain() {}
-void _register_fs() {}
-void _register_fs_event_wrap() {}
-void _register_http2() {}
-void _register_http_parser() {}
-void _register_js_stream() {}
-void _register_module_wrap() {}
-void _register_os() {}
-void _register_pipe_wrap() {}
-void _register_process_wrap() {}
-void _register_serdes() {}
-void _register_signal_wrap() {}
-void _register_spawn_sync() {}
-void _register_stream_wrap() {}
-void _register_tcp_wrap() {}
-void _register_timer_wrap() {}
-void _register_trace_events() {}
-void _register_tty_wrap() {}
-void _register_udp_wrap() {}
-void _register_util() {}
-void _register_uv() {}
-void _register_v8() {}
-void _register_zlib() {}
diff --git a/test/cctest/test_node_postmortem_metadata.cc b/test/cctest/test_node_postmortem_metadata.cc
index be5cc7ce8a..e901d97668 100644
--- a/test/cctest/test_node_postmortem_metadata.cc
+++ b/test/cctest/test_node_postmortem_metadata.cc
@@ -1,5 +1,3 @@
-#include "node_postmortem_metadata.cc"
-
 #include "gtest/gtest.h"
 #include "node.h"
 #include "node_internals.h"
@@ -7,6 +5,28 @@
 #include "req_wrap-inl.h"
 #include "tracing/agent.h"
 #include "v8.h"
+#include "v8abbr.h"
+
+extern "C" {
+extern uintptr_t
+    nodedbg_offset_HandleWrap__handle_wrap_queue___ListNode_HandleWrap;
+extern uintptr_t
+    nodedbg_offset_Environment__handle_wrap_queue___Environment_HandleWrapQueue;
+extern int debug_symbols_generated;
+extern int nodedbg_const_Environment__kContextEmbedderDataIndex__int;
+extern uintptr_t
+    nodedbg_offset_Environment_HandleWrapQueue__head___ListNode_HandleWrap;
+extern uintptr_t
+    nodedbg_offset_Environment__req_wrap_queue___Environment_ReqWrapQueue;
+extern uintptr_t nodedbg_offset_ExternalString__data__uintptr_t;
+extern uintptr_t nodedbg_offset_ListNode_ReqWrap__next___uintptr_t;
+extern uintptr_t nodedbg_offset_ReqWrap__req_wrap_queue___ListNode_ReqWrapQueue;
+extern uintptr_t nodedbg_offset_ListNode_HandleWrap__next___uintptr_t;
+extern uintptr_t
+    nodedbg_offset_Environment_ReqWrapQueue__head___ListNode_ReqWrapQueue;
+extern uintptr_t
+    nodedbg_offset_BaseObject__persistent_handle___v8_Persistent_v8_Object;
+}
 
 
 class DebugSymbolsTest : public EnvironmentTestFixture {};