summaryrefslogtreecommitdiff
path: root/test/cctest
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2017-08-08 19:56:02 +0200
committerAnna Henningsen <anna@addaleax.net>2017-09-14 17:38:38 +0200
commit290315ace7eed6eeeb300754dd68fc1af4d80c9b (patch)
treedb8e56c9709d43c202c58a0576091e77eb2c44c9 /test/cctest
parent4ae0afb12b6d29c8bb743c4fd560a91fd626b558 (diff)
downloadandroid-node-v8-290315ace7eed6eeeb300754dd68fc1af4d80c9b.tar.gz
android-node-v8-290315ace7eed6eeeb300754dd68fc1af4d80c9b.tar.bz2
android-node-v8-290315ace7eed6eeeb300754dd68fc1af4d80c9b.zip
src: refactor `#include` handling
`node_internals.h` already includes the most common headers, so double includes can be avoided in a lot of cases. Also don’t include `node_internals.h` from `node.h` implicitly anymore, as that is mostly unnecessary. PR-URL: https://github.com/nodejs/node/pull/14697 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/cctest')
-rw-r--r--test/cctest/node_test_fixture.h1
-rw-r--r--test/cctest/test_environment.cc4
2 files changed, 2 insertions, 3 deletions
diff --git a/test/cctest/node_test_fixture.h b/test/cctest/node_test_fixture.h
index 79027d25ad..263f7b96f9 100644
--- a/test/cctest/node_test_fixture.h
+++ b/test/cctest/node_test_fixture.h
@@ -4,6 +4,7 @@
#include <stdlib.h>
#include "gtest/gtest.h"
#include "node.h"
+#include "node_platform.h"
#include "env.h"
#include "v8.h"
#include "libplatform/libplatform.h"
diff --git a/test/cctest/test_environment.cc b/test/cctest/test_environment.cc
index 4651e865a9..8beacfa95e 100644
--- a/test/cctest/test_environment.cc
+++ b/test/cctest/test_environment.cc
@@ -1,6 +1,4 @@
-#include "node.h"
-#include "env.h"
-#include "v8.h"
+#include "node_internals.h"
#include "libplatform/libplatform.h"
#include <string>