diff options
author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2017-05-23 08:28:13 +0200 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2017-05-25 17:54:49 +0200 |
commit | 25ade76fb01258d8a789a9cd893b284542827efd (patch) | |
tree | 83a1cbb76c35fd66a5fd0ab4e6a0223bebad6f49 /test/cctest | |
parent | 155687cb7ee23d7777d1072c4c2956564bff8ac4 (diff) | |
download | android-node-v8-25ade76fb01258d8a789a9cd893b284542827efd.tar.gz android-node-v8-25ade76fb01258d8a789a9cd893b284542827efd.tar.bz2 android-node-v8-25ade76fb01258d8a789a9cd893b284542827efd.zip |
test: add override to ServerDone function
Currently the following compiler warning is displayed when building:
../test/cctest/test_inspector_socket_server.cc:142:8: warning:
'ServerDone' overrides a member function but is not marked 'override'
[-Winconsistent-missing-override]
void ServerDone() {
^
../src/inspector_socket_server.h:30:16: note: overridden virtual
function is here
virtual void ServerDone() = 0;
^
This commit marks ServerDone with override to get rid of the warning.
PR-URL: https://github.com/nodejs/node/pull/13166
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'test/cctest')
-rw-r--r-- | test/cctest/test_inspector_socket_server.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/cctest/test_inspector_socket_server.cc b/test/cctest/test_inspector_socket_server.cc index 356ef41070..4e292691c1 100644 --- a/test/cctest/test_inspector_socket_server.cc +++ b/test/cctest/test_inspector_socket_server.cc @@ -139,7 +139,7 @@ class TestInspectorServerDelegate : public SocketServerDelegate { server_->Send(session_id_, message); } - void ServerDone() { + void ServerDone() override { done = true; } |