diff options
author | Anatoli Papirovski <apapirovski@mac.com> | 2018-05-13 17:42:22 +0200 |
---|---|---|
committer | Anatoli Papirovski <apapirovski@mac.com> | 2018-06-24 21:35:05 -0700 |
commit | 2930bd1317d15d12738a4896c0a6c05700411b47 (patch) | |
tree | 5c9225b9740c79d83ea2ded69d63b94a66846036 /test/cctest/test_node_postmortem_metadata.cc | |
parent | 6f63f8d730c8c3b19de7a591c35d376d428a4d56 (diff) | |
download | android-node-v8-2930bd1317d15d12738a4896c0a6c05700411b47.tar.gz android-node-v8-2930bd1317d15d12738a4896c0a6c05700411b47.tar.bz2 android-node-v8-2930bd1317d15d12738a4896c0a6c05700411b47.zip |
src: refactor timers to remove TimerWrap
Refactor Timers to behave more similarly to Immediates by having
a single uv_timer_t handle which is stored on the Environment.
No longer expose timers in a public binding and instead make
it part of the internalBinding.
PR-URL: https://github.com/nodejs/node/pull/20894
Fixes: https://github.com/nodejs/node/issues/10154
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Diffstat (limited to 'test/cctest/test_node_postmortem_metadata.cc')
-rw-r--r-- | test/cctest/test_node_postmortem_metadata.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/cctest/test_node_postmortem_metadata.cc b/test/cctest/test_node_postmortem_metadata.cc index f69df3ed22..b911a92c0d 100644 --- a/test/cctest/test_node_postmortem_metadata.cc +++ b/test/cctest/test_node_postmortem_metadata.cc @@ -42,7 +42,7 @@ class TestHandleWrap : public node::HandleWrap { : node::HandleWrap(env, object, reinterpret_cast<uv_handle_t*>(handle), - node::AsyncWrap::PROVIDER_TIMERWRAP) {} + node::AsyncWrap::PROVIDER_TCPWRAP) {} }; @@ -53,7 +53,7 @@ class TestReqWrap : public node::ReqWrap<uv_req_t> { TestReqWrap(node::Environment* env, v8::Local<v8::Object> object) : node::ReqWrap<uv_req_t>(env, object, - node::AsyncWrap::PROVIDER_TIMERWRAP) {} + node::AsyncWrap::PROVIDER_FSREQWRAP) {} }; TEST_F(DebugSymbolsTest, ContextEmbedderEnvironmentIndex) { |