diff options
| author | Jimmy Thomson <jithomso@microsoft.com> | 2017-07-06 11:42:28 -0700 |
|---|---|---|
| committer | Refael Ackermann <refack@gmail.com> | 2017-07-10 12:33:21 -0400 |
| commit | 94dd42577c8aa3a3c2f812ad68b3fe55da546eb5 (patch) | |
| tree | 6986ee92951048e65d41a639fba39bc4eee08d55 /test/cctest/test_inspector_socket_server.cc | |
| parent | ff07eaa140e54745a5298f4c929936cfe055ed3c (diff) | |
| download | android-node-v8-94dd42577c8aa3a3c2f812ad68b3fe55da546eb5.tar.gz android-node-v8-94dd42577c8aa3a3c2f812ad68b3fe55da546eb5.tar.bz2 android-node-v8-94dd42577c8aa3a3c2f812ad68b3fe55da546eb5.zip | |
test: fix cctest failure on Windows
Linux converts the ipv6 address "::" to "::1", while windows does not.
By explicitly using "::1" in the test we allow it to succeed on windows.
PR-URL: https://github.com/nodejs/node/pull/14111
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/cctest/test_inspector_socket_server.cc')
| -rw-r--r-- | test/cctest/test_inspector_socket_server.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/cctest/test_inspector_socket_server.cc b/test/cctest/test_inspector_socket_server.cc index 61cf286729..f9814274d0 100644 --- a/test/cctest/test_inspector_socket_server.cc +++ b/test/cctest/test_inspector_socket_server.cc @@ -621,7 +621,7 @@ TEST_F(InspectorSocketServerTest, BindsToIpV6) { ASSERT_TRUE(server->Start()); SocketWrapper socket1(&loop); - socket1.Connect("::", server.port(), true); + socket1.Connect("::1", server.port(), true); socket1.Write(WsHandshakeRequest(MAIN_TARGET_ID)); socket1.Expect(WS_HANDSHAKE_RESPONSE); server->Stop(ServerHolder::CloseCallback); |