diff options
| author | gengjiawen <technicalcute@gmail.com> | 2019-02-11 17:20:52 +0800 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-02-19 12:54:41 +0100 |
| commit | 8375c706ad51a399451e4f43b075f3795c440dad (patch) | |
| tree | a8eaa7d4fae2f3e6ff8b56a62569d9d48c3e1245 /test/cctest/test_inspector_socket_server.cc | |
| parent | b200a46befd936cbf1b5356045d88ba9e8156e87 (diff) | |
| download | android-node-v8-8375c706ad51a399451e4f43b075f3795c440dad.tar.gz android-node-v8-8375c706ad51a399451e4f43b075f3795c440dad.tar.bz2 android-node-v8-8375c706ad51a399451e4f43b075f3795c440dad.zip | |
src: apply clang-tidy rule performance-unnecessary-value-param
PR-URL: https://github.com/nodejs/node/pull/26042
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/cctest/test_inspector_socket_server.cc')
| -rw-r--r-- | test/cctest/test_inspector_socket_server.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/test/cctest/test_inspector_socket_server.cc b/test/cctest/test_inspector_socket_server.cc index 30da5cf3d2..5797708483 100644 --- a/test/cctest/test_inspector_socket_server.cc +++ b/test/cctest/test_inspector_socket_server.cc @@ -92,7 +92,7 @@ class SocketWrapper { connected_(false), sending_(false) { } - void Connect(std::string host, int port, bool v6 = false) { + void Connect(const std::string& host, int port, bool v6 = false) { closed_ = false; connection_failed_ = false; connected_ = false; @@ -114,7 +114,7 @@ class SocketWrapper { ReadCallback); } - void ExpectFailureToConnect(std::string host, int port) { + void ExpectFailureToConnect(const std::string& host, int port) { connected_ = false; connection_failed_ = false; closed_ = false; @@ -243,7 +243,7 @@ class ServerHolder { : ServerHolder(has_targets, loop, HOST, port, nullptr) { } ServerHolder(bool has_targets, uv_loop_t* loop, - const std::string host, int port, FILE* out); + const std::string& host, int port, FILE* out); InspectorSocketServer* operator->() { return server_.get(); @@ -350,7 +350,7 @@ class TestSocketServerDelegate : public SocketServerDelegate { }; ServerHolder::ServerHolder(bool has_targets, uv_loop_t* loop, - const std::string host, int port, FILE* out) { + const std::string& host, int port, FILE* out) { std::vector<std::string> targets; if (has_targets) targets = { MAIN_TARGET_ID }; |