diff options
| author | Eugene Ostroukhov <eostroukhov@chromium.org> | 2017-06-22 10:43:03 -0700 |
|---|---|---|
| committer | Eugene Ostroukhov <eostroukhov@chromium.org> | 2017-06-26 10:28:13 -0700 |
| commit | 5fbbd25dc4133ed57f4904dfeee716a02e3817c9 (patch) | |
| tree | 9560066a732c098ccd7d59f33eb1c92255341e28 /test/cctest/test_inspector_socket_server.cc | |
| parent | 6bf4c23295ea4dceca0ae47f354ec4ec3836917f (diff) | |
| download | android-node-v8-5fbbd25dc4133ed57f4904dfeee716a02e3817c9.tar.gz android-node-v8-5fbbd25dc4133ed57f4904dfeee716a02e3817c9.tar.bz2 android-node-v8-5fbbd25dc4133ed57f4904dfeee716a02e3817c9.zip | |
test: check uv_ip4_addr return value
Fixes Coverity errors.
PR-URL: https://github.com/nodejs/node/pull/13878
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'test/cctest/test_inspector_socket_server.cc')
| -rw-r--r-- | test/cctest/test_inspector_socket_server.cc | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/test/cctest/test_inspector_socket_server.cc b/test/cctest/test_inspector_socket_server.cc index a8c3bcd2f7..61cf286729 100644 --- a/test/cctest/test_inspector_socket_server.cc +++ b/test/cctest/test_inspector_socket_server.cc @@ -194,10 +194,11 @@ class SocketWrapper { contents_.clear(); uv_tcp_init(loop_, &socket_); sockaddr_in addr; - uv_ip4_addr(host.c_str(), port, &addr); - int err = uv_tcp_connect(&connect_, &socket_, - reinterpret_cast<const sockaddr*>(&addr), - ConnectionMustFail_); + int err = uv_ip4_addr(host.c_str(), port, &addr); + ASSERT_EQ(0, err); + err = uv_tcp_connect(&connect_, &socket_, + reinterpret_cast<const sockaddr*>(&addr), + ConnectionMustFail_); ASSERT_EQ(0, err); SPIN_WHILE(!connection_failed_) uv_read_start(reinterpret_cast<uv_stream_t*>(&socket_), AllocCallback, |