diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-06-20 09:09:33 +0200 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-06-27 05:19:30 +0200 |
| commit | d6f7a32570994b21c628b517b3ddc863a1f059fb (patch) | |
| tree | 5f7d29d095f13647ab1657e71a9c8398cac7a787 /test/cctest/test_environment.cc | |
| parent | 4f67c6f667fa98e25ba311d3459fc8e270407250 (diff) | |
| download | android-node-v8-d6f7a32570994b21c628b517b3ddc863a1f059fb.tar.gz android-node-v8-d6f7a32570994b21c628b517b3ddc863a1f059fb.tar.bz2 android-node-v8-d6f7a32570994b21c628b517b3ddc863a1f059fb.zip | |
test: make cctest fixture use node::NewIsolate
This commit updates the gtest fixture to use node::NewIsolate instead of
creating a new V8 Isolate using v8::Isolate::New.
The motivation for this is that without calling node::NewIsolate the
various callbacks set on the isolate, for example AddMessageListener,
SetFatalErrorHandler etc, would not get set. I don't think this is the
expected behaviour and I ran into this when writing a new cctest.
PR-URL: https://github.com/nodejs/node/pull/21419
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'test/cctest/test_environment.cc')
0 files changed, 0 insertions, 0 deletions