summaryrefslogtreecommitdiff
path: root/test/cctest/node_test_fixture.h
diff options
context:
space:
mode:
authorMike Kaufman <mike.kaufman@microsoft.com>2017-08-25 12:45:00 -0700
committerAnna Henningsen <anna@addaleax.net>2017-09-13 17:44:24 +0200
commit35a526c1d4702d54c464510f448879f096a97321 (patch)
treed5147ecaf5e86bc429af38f01d994d4b2edd5fdf /test/cctest/node_test_fixture.h
parent2ac7b433b42dd44b319e1113e045dda8df20a4f8 (diff)
downloadandroid-node-v8-35a526c1d4702d54c464510f448879f096a97321.tar.gz
android-node-v8-35a526c1d4702d54c464510f448879f096a97321.tar.bz2
android-node-v8-35a526c1d4702d54c464510f448879f096a97321.zip
http2,async-wrap: introduce AliasedBuffer class
This change introduces an AliasedBuffer class and updates asytnc-wrap and http2 to use this class. A common technique to optimize performance is to create a native buffer and then map that native buffer to user space via JS array. The runtime can efficiently write to the native buffer without having to route though JS, and the values being written are accessible from user space. While efficient, this technique allows modifications to user space memory w/out going through JS type system APIs, effectively bypassing any monitoring the JS VM has in place to track program state modifications. The result is that monitors have an incorrect view of prorgram state. The AliasedBuffer class provides a future placeholder where this technique can be used, but writes can still be observed. To achieve this, the node-chakra-core fork will add in appropriate tracking logic in the AliasedBuffer's SetValue() method. Going forward, this class can evolve to support more sophisticated mechanisms if necessary. PR-URL: https://github.com/nodejs/node/pull/15077 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'test/cctest/node_test_fixture.h')
-rw-r--r--test/cctest/node_test_fixture.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/test/cctest/node_test_fixture.h b/test/cctest/node_test_fixture.h
index f30823a8fd..79027d25ad 100644
--- a/test/cctest/node_test_fixture.h
+++ b/test/cctest/node_test_fixture.h
@@ -66,7 +66,7 @@ struct Argv {
int nr_args_;
};
-uv_loop_t current_loop;
+extern uv_loop_t current_loop;
class NodeTestFixture : public ::testing::Test {
public: