diff options
| author | Rich Trott <rtrott@gmail.com> | 2017-11-22 14:39:38 -0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2017-12-05 00:07:27 -0800 |
| commit | e18390032e6cdf35c0a62e0c6da8c6d53b8c4f38 (patch) | |
| tree | 70ae08309284ec937ac4068a918423608bb03f5e /test/async-hooks/test-tcpwrap.js | |
| parent | 35c01d84a837c4f57b0bac04e27c58c86d2f8c91 (diff) | |
| download | android-node-v8-e18390032e6cdf35c0a62e0c6da8c6d53b8c4f38.tar.gz android-node-v8-e18390032e6cdf35c0a62e0c6da8c6d53b8c4f38.tar.bz2 android-node-v8-e18390032e6cdf35c0a62e0c6da8c6d53b8c4f38.zip | |
test: remove common.PORT from parallel tests
`common.PORT` should not be used in parallel tests because another test
may experience a collision with `common.PORT` when using port 0 to get
an open port. This has been observed to result in test failures in CI.
PR-URL: https://github.com/nodejs/node/pull/17410
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Diffstat (limited to 'test/async-hooks/test-tcpwrap.js')
| -rw-r--r-- | test/async-hooks/test-tcpwrap.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/async-hooks/test-tcpwrap.js b/test/async-hooks/test-tcpwrap.js index e7d879caf7..f3100aba0f 100644 --- a/test/async-hooks/test-tcpwrap.js +++ b/test/async-hooks/test-tcpwrap.js @@ -24,7 +24,7 @@ const server = net // Calling server.listen creates a TCPWRAP synchronously { - server.listen(common.PORT); + server.listen(0); const tcpsservers = hooks.activitiesOfTypes('TCPSERVERWRAP'); const tcpconnects = hooks.activitiesOfTypes('TCPCONNECTWRAP'); assert.strictEqual(tcpsservers.length, 1); |