diff options
author | Anna Henningsen <anna@addaleax.net> | 2017-05-26 17:53:06 +0200 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2017-06-03 23:08:24 +0200 |
commit | 1dc3272bb9c2ecd442efd5b978a852a7da31c1e9 (patch) | |
tree | d835fa61e0503a8b5c4405c03003085129c2d0fe /test/async-hooks/test-signalwrap.js | |
parent | 8741e3c7501cbe66696bd3fad4a0a923e76ba11d (diff) | |
download | android-node-v8-1dc3272bb9c2ecd442efd5b978a852a7da31c1e9.tar.gz android-node-v8-1dc3272bb9c2ecd442efd5b978a852a7da31c1e9.tar.bz2 android-node-v8-1dc3272bb9c2ecd442efd5b978a852a7da31c1e9.zip |
test: improve async hooks test error messages
Improve error messages in the async hooks tests, mostly by removing
unhelpful `message` parameters for assertions.
PR-URL: https://github.com/nodejs/node/pull/13243
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Diffstat (limited to 'test/async-hooks/test-signalwrap.js')
-rw-r--r-- | test/async-hooks/test-signalwrap.js | 20 |
1 files changed, 8 insertions, 12 deletions
diff --git a/test/async-hooks/test-signalwrap.js b/test/async-hooks/test-signalwrap.js index 1065616032..3b1cffbb8c 100644 --- a/test/async-hooks/test-signalwrap.js +++ b/test/async-hooks/test-signalwrap.js @@ -12,12 +12,11 @@ hooks.enable(); process.on('SIGUSR2', common.mustCall(onsigusr2, 2)); const as = hooks.activitiesOfTypes('SIGNALWRAP'); -assert.strictEqual(as.length, 1, - 'one signal wrap when SIGUSR2 handler is set up'); +assert.strictEqual(as.length, 1); const signal1 = as[0]; -assert.strictEqual(signal1.type, 'SIGNALWRAP', 'signal wrap'); -assert.strictEqual(typeof signal1.uid, 'number', 'uid is a number'); -assert.strictEqual(typeof signal1.triggerId, 'number', 'triggerId is a number'); +assert.strictEqual(signal1.type, 'SIGNALWRAP'); +assert.strictEqual(typeof signal1.uid, 'number'); +assert.strictEqual(typeof signal1.triggerId, 'number'); checkInvocations(signal1, { init: 1 }, 'when SIGUSR2 handler is set up'); let count = 0; @@ -47,14 +46,11 @@ function onsigusr2() { process.on('SIGUSR2', common.mustCall(onsigusr2Again)); const as = hooks.activitiesOfTypes('SIGNALWRAP'); - assert.strictEqual( - as.length, 2, - 'two signal wraps when second SIGUSR2 handler is set up'); + assert.strictEqual(as.length, 2); signal2 = as[1]; - assert.strictEqual(signal2.type, 'SIGNALWRAP', 'signal wrap'); - assert.strictEqual(typeof signal2.uid, 'number', 'uid is a number'); - assert.strictEqual(typeof signal2.triggerId, 'number', - 'triggerId is a number'); + assert.strictEqual(signal2.type, 'SIGNALWRAP'); + assert.strictEqual(typeof signal2.uid, 'number'); + assert.strictEqual(typeof signal2.triggerId, 'number'); checkInvocations( signal1, { init: 1, before: 2, after: 1 }, |