diff options
| author | Santiago Gimeno <santiago.gimeno@gmail.com> | 2018-02-06 18:31:14 +0100 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-02-16 19:11:03 +0100 |
| commit | b74a6da5d004fa43f88475d95b1ca910206eccb7 (patch) | |
| tree | 55e131eaeb972d1a105c272fa58ee55b0f4ff0ae /test/async-hooks/test-pipewrap.js | |
| parent | f25104e1364cf7c56ae4a09a86b64a87de326ec3 (diff) | |
| download | android-node-v8-b74a6da5d004fa43f88475d95b1ca910206eccb7.tar.gz android-node-v8-b74a6da5d004fa43f88475d95b1ca910206eccb7.tar.bz2 android-node-v8-b74a6da5d004fa43f88475d95b1ca910206eccb7.zip | |
child_process: fix stdio sockets creation
`readable` and `writable` properties can be passed directly to the
`net.Socket` constructor. This change also avoids an unnecessary call
to `read(0)` on the `stdin` socket. This behavior was disclosed when
trying to merge `libuv@1.19.0` and specifically this commit:
https://github.com/libuv/libuv/commit/fd049399aa4ed8495928e375466970d98cb42e17.
PR-URL: https://github.com/nodejs/node/pull/18701
Refs: https://github.com/libuv/libuv/pull/1655
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test/async-hooks/test-pipewrap.js')
| -rw-r--r-- | test/async-hooks/test-pipewrap.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/async-hooks/test-pipewrap.js b/test/async-hooks/test-pipewrap.js index 550de7907a..066458841f 100644 --- a/test/async-hooks/test-pipewrap.js +++ b/test/async-hooks/test-pipewrap.js @@ -78,7 +78,7 @@ function onexit() { // Usually it is just one event, but it can be more. assert.ok(ioEvents >= 3, `at least 3 stdout io events, got ${ioEvents}`); - checkInvocations(pipe1, { init: 1, before: 2, after: 2 }, + checkInvocations(pipe1, { init: 1, before: 1, after: 1 }, 'pipe wrap when sleep.spawn was called'); checkInvocations(pipe2, { init: 1, before: ioEvents, after: ioEvents }, 'pipe wrap when sleep.spawn was called'); |