diff options
author | Refael Ackermann <refack@gmail.com> | 2019-06-02 16:19:26 -0400 |
---|---|---|
committer | Refael Ackermann <refack@gmail.com> | 2019-06-06 19:38:16 -0400 |
commit | 59f666cd39847d2de391ed4cd551c9eefda975d3 (patch) | |
tree | 47cc9698aaba8eb1aa1a6d9e8a9e437b7f67d150 /test/async-hooks/test-pipeconnectwrap.js | |
parent | 546d6cdd9e70a9e25b3c43e88d3acac875a478f8 (diff) | |
download | android-node-v8-59f666cd39847d2de391ed4cd551c9eefda975d3.tar.gz android-node-v8-59f666cd39847d2de391ed4cd551c9eefda975d3.tar.bz2 android-node-v8-59f666cd39847d2de391ed4cd551c9eefda975d3.zip |
test: shell out to `rmdir` first on Windows
cmd's `rmdir` is hardened to deal with Windows edge cases, like
lingering processes, indexing, and AV checks. So we give it a try first.
* Added `opts = { spawn = true }` to opt-out of spawning
* test-pipeconnectwrap.js - spawning messes up async_hooks state
PR-URL: https://github.com/nodejs/node/pull/28035
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Diffstat (limited to 'test/async-hooks/test-pipeconnectwrap.js')
-rw-r--r-- | test/async-hooks/test-pipeconnectwrap.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/async-hooks/test-pipeconnectwrap.js b/test/async-hooks/test-pipeconnectwrap.js index 5d3706ac44..f086807e39 100644 --- a/test/async-hooks/test-pipeconnectwrap.js +++ b/test/async-hooks/test-pipeconnectwrap.js @@ -5,11 +5,11 @@ const assert = require('assert'); const tick = require('../common/tick'); const initHooks = require('./init-hooks'); const { checkInvocations } = require('./hook-checks'); - +const tmpdir = require('../common/tmpdir'); const net = require('net'); -const tmpdir = require('../common/tmpdir'); -tmpdir.refresh(); +// Spawning messes up `async_hooks` state. +tmpdir.refresh({ spawn: false }); const hooks = initHooks(); hooks.enable(); |