summaryrefslogtreecommitdiff
path: root/test/async-hooks/test-immediate.js
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2017-05-26 17:53:06 +0200
committerAnna Henningsen <anna@addaleax.net>2017-06-03 23:08:24 +0200
commit1dc3272bb9c2ecd442efd5b978a852a7da31c1e9 (patch)
treed835fa61e0503a8b5c4405c03003085129c2d0fe /test/async-hooks/test-immediate.js
parent8741e3c7501cbe66696bd3fad4a0a923e76ba11d (diff)
downloadandroid-node-v8-1dc3272bb9c2ecd442efd5b978a852a7da31c1e9.tar.gz
android-node-v8-1dc3272bb9c2ecd442efd5b978a852a7da31c1e9.tar.bz2
android-node-v8-1dc3272bb9c2ecd442efd5b978a852a7da31c1e9.zip
test: improve async hooks test error messages
Improve error messages in the async hooks tests, mostly by removing unhelpful `message` parameters for assertions. PR-URL: https://github.com/nodejs/node/pull/13243 Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Diffstat (limited to 'test/async-hooks/test-immediate.js')
-rw-r--r--test/async-hooks/test-immediate.js21
1 files changed, 9 insertions, 12 deletions
diff --git a/test/async-hooks/test-immediate.js b/test/async-hooks/test-immediate.js
index 2434d98003..e5bce88de9 100644
--- a/test/async-hooks/test-immediate.js
+++ b/test/async-hooks/test-immediate.js
@@ -13,12 +13,11 @@ hooks.enable();
setImmediate(common.mustCall(onimmediate));
const as = hooks.activitiesOfTypes('Immediate');
-assert.strictEqual(as.length, 1,
- 'one immediate when first set immediate installed');
+assert.strictEqual(as.length, 1);
const imd1 = as[0];
-assert.strictEqual(imd1.type, 'Immediate', 'immediate');
-assert.strictEqual(typeof imd1.uid, 'number', 'uid is a number');
-assert.strictEqual(typeof imd1.triggerId, 'number', 'triggerId is a number');
+assert.strictEqual(imd1.type, 'Immediate');
+assert.strictEqual(typeof imd1.uid, 'number');
+assert.strictEqual(typeof imd1.triggerId, 'number');
checkInvocations(imd1, { init: 1 },
'imd1: when first set immediate installed');
@@ -26,20 +25,18 @@ let imd2;
function onimmediate() {
let as = hooks.activitiesOfTypes('Immediate');
- assert.strictEqual(as.length, 1,
- 'one immediate when first set immediate triggered');
+ assert.strictEqual(as.length, 1);
checkInvocations(imd1, { init: 1, before: 1 },
'imd1: when first set immediate triggered');
// install second immediate
setImmediate(common.mustCall(onimmediateTwo));
as = hooks.activitiesOfTypes('Immediate');
- assert.strictEqual(as.length, 2,
- 'two immediates when second set immediate installed');
+ assert.strictEqual(as.length, 2);
imd2 = as[1];
- assert.strictEqual(imd2.type, 'Immediate', 'immediate');
- assert.strictEqual(typeof imd2.uid, 'number', 'uid is a number');
- assert.strictEqual(typeof imd2.triggerId, 'number', 'triggerId is a number');
+ assert.strictEqual(imd2.type, 'Immediate');
+ assert.strictEqual(typeof imd2.uid, 'number');
+ assert.strictEqual(typeof imd2.triggerId, 'number');
checkInvocations(imd1, { init: 1, before: 1 },
'imd1: when second set immediate installed');
checkInvocations(imd2, { init: 1 },