diff options
author | Anna Henningsen <anna@addaleax.net> | 2017-05-26 17:53:06 +0200 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2017-06-03 23:08:24 +0200 |
commit | 1dc3272bb9c2ecd442efd5b978a852a7da31c1e9 (patch) | |
tree | d835fa61e0503a8b5c4405c03003085129c2d0fe /test/async-hooks/test-getaddrinforeqwrap.js | |
parent | 8741e3c7501cbe66696bd3fad4a0a923e76ba11d (diff) | |
download | android-node-v8-1dc3272bb9c2ecd442efd5b978a852a7da31c1e9.tar.gz android-node-v8-1dc3272bb9c2ecd442efd5b978a852a7da31c1e9.tar.bz2 android-node-v8-1dc3272bb9c2ecd442efd5b978a852a7da31c1e9.zip |
test: improve async hooks test error messages
Improve error messages in the async hooks tests, mostly by removing
unhelpful `message` parameters for assertions.
PR-URL: https://github.com/nodejs/node/pull/13243
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Diffstat (limited to 'test/async-hooks/test-getaddrinforeqwrap.js')
-rw-r--r-- | test/async-hooks/test-getaddrinforeqwrap.js | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/test/async-hooks/test-getaddrinforeqwrap.js b/test/async-hooks/test-getaddrinforeqwrap.js index 0bbe89f327..b99ba2832b 100644 --- a/test/async-hooks/test-getaddrinforeqwrap.js +++ b/test/async-hooks/test-getaddrinforeqwrap.js @@ -16,12 +16,12 @@ function onlookup(err_, ip, family) { // tests to run offline (lookup will fail in that case and the err be set); const as = hooks.activitiesOfTypes('GETADDRINFOREQWRAP'); - assert.strictEqual(as.length, 1, 'one activity'); + assert.strictEqual(as.length, 1); const a = as[0]; - assert.strictEqual(a.type, 'GETADDRINFOREQWRAP', 'getaddrinforeq wrap'); - assert.strictEqual(typeof a.uid, 'number', 'uid is a number'); - assert.strictEqual(a.triggerId, 1, 'parent uid 1'); + assert.strictEqual(a.type, 'GETADDRINFOREQWRAP'); + assert.strictEqual(typeof a.uid, 'number'); + assert.strictEqual(a.triggerId, 1); checkInvocations(a, { init: 1, before: 1 }, 'while in onlookup callback'); tick(2); } |