diff options
| author | Gerhard Stoebich <18708370+Flarna@users.noreply.github.com> | 2019-04-23 00:57:12 +0200 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-05-03 16:02:55 +0200 |
| commit | 8876ac5c358114f0f88424f6737ca4b89fc9e6c7 (patch) | |
| tree | 5b0804517e873f3c08b236104b11f26dd752f941 /test/async-hooks/coverage.md | |
| parent | 8dae89b396df64e6a9e44cb94efe27809a5a3d89 (diff) | |
| download | android-node-v8-8876ac5c358114f0f88424f6737ca4b89fc9e6c7.tar.gz android-node-v8-8876ac5c358114f0f88424f6737ca4b89fc9e6c7.tar.bz2 android-node-v8-8876ac5c358114f0f88424f6737ca4b89fc9e6c7.zip | |
async_hooks: fixup do not reuse HTTPParser
Fix some issues introduced/not fixed via
https://github.com/nodejs/node/pull/25094:
* Init hook is not emitted for a reused HTTPParser
* HTTPParser was still used as resource in init hook
* type used in init hook was always HTTPINCOMINGMESSAGE even for client
requests
* some tests have not been adapted to new resource names
With this change the async hooks init event is emitted during a call
to Initialize() as the type and resource object is available at this
time. As a result Initialize() must be called now which could be seen
as breaking change even HTTPParser is not part of documented API.
It was needed to put the ClientRequest instance into a wrapper object
instead passing it directly as async resource otherwise
test-domain-multi fails. I think this is because adding an EventEmitter
to a Domain adds a property 'domain' and the presence of this changes
the context propagation in domains.
Besides that tests still refering to resource HTTPParser have been
updated/improved.
Fixes: https://github.com/nodejs/node/issues/27467
Fixes: https://github.com/nodejs/node/issues/26961
Refs: https://github.com/nodejs/node/pull/25094
PR-URL: https://github.com/nodejs/node/pull/27477
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'test/async-hooks/coverage.md')
| -rw-r--r-- | test/async-hooks/coverage.md | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/test/async-hooks/coverage.md b/test/async-hooks/coverage.md index 0a2af0d06b..1ba18a9383 100644 --- a/test/async-hooks/coverage.md +++ b/test/async-hooks/coverage.md @@ -9,7 +9,8 @@ Showing which kind of async resource is covered by which test: | FSREQCALLBACK | test-fsreqcallback-{access,readFile}.js | | GETADDRINFOREQWRAP | test-getaddrinforeqwrap.js | | GETNAMEINFOREQWRAP | test-getnameinforeqwrap.js | -| HTTPPARSER | test-httpparser.{request,response}.js | +| HTTPINCOMINGMESSAGE | test-httpparser.request.js | +| HTTPCLIENTREQUEST | test-httpparser.response.js | | Immediate | test-immediate.js | | JSSTREAM | TODO (crashes when accessing directly) | | PBKDF2REQUEST | test-crypto-pbkdf2.js | |