diff options
author | Christopher Hiller <boneskull@boneskull.com> | 2019-07-10 13:27:44 -0700 |
---|---|---|
committer | Christopher Hiller <boneskull@boneskull.com> | 2019-07-12 14:48:09 -0700 |
commit | bff7a46f31f1da259071a1f4bd51aca726d5926e (patch) | |
tree | 16b62a84d9cc3ad1b5893bbb1d7039df066557ea /test/addons | |
parent | 28e18cfff0d491e14889935a64395cbbb5b666a6 (diff) | |
download | android-node-v8-bff7a46f31f1da259071a1f4bd51aca726d5926e.tar.gz android-node-v8-bff7a46f31f1da259071a1f4bd51aca726d5926e.tar.bz2 android-node-v8-bff7a46f31f1da259071a1f4bd51aca726d5926e.zip |
report: modify getReport() to return an Object
It's likely that anyone using `process.report.getReport()` will be
processing the return value thereafter (e.g., filtering fields or
redacting secrets). This change eliminates boilerplate by calling
`JSON.parse()` on the return value.
Also modified the `validateContent()` and `validate()` test helpers in
`test/common/report.js` to be somewhat more obvious and helpful. Of
note, a report failing validation will now be easier (though still not
_easy_) to read when prepended to the stack trace.
- Refs: https://github.com/nodejs/diagnostics/issues/315
PR-URL: https://github.com/nodejs/node/pull/28630
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'test/addons')
-rw-r--r-- | test/addons/worker-addon/test.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/addons/worker-addon/test.js b/test/addons/worker-addon/test.js index ef158e98b1..85a5e27016 100644 --- a/test/addons/worker-addon/test.js +++ b/test/addons/worker-addon/test.js @@ -31,7 +31,7 @@ switch (process.argv[2]) { } // Use process.report to figure out if we might be running under musl libc. -const glibc = JSON.parse(process.report.getReport()).header.glibcVersionRuntime; +const glibc = process.report.getReport().header.glibcVersionRuntime; assert(typeof glibc === 'string' || glibc === undefined, glibc); const libcMayBeMusl = common.isLinux && glibc === undefined; |