diff options
| author | Sam Roberts <vieuxtech@gmail.com> | 2019-07-02 14:35:18 -0700 |
|---|---|---|
| committer | Sam Roberts <vieuxtech@gmail.com> | 2019-07-04 13:03:58 -0700 |
| commit | 1245aca41ca91e60cc4cee2cd724d28b73534ace (patch) | |
| tree | c9bfad97f6908dba1e2fedbb2bf430dafa245794 /test/addons | |
| parent | 39a935883df8cc87e1bd6364df38a61131e1e4ba (diff) | |
| download | android-node-v8-1245aca41ca91e60cc4cee2cd724d28b73534ace.tar.gz android-node-v8-1245aca41ca91e60cc4cee2cd724d28b73534ace.tar.bz2 android-node-v8-1245aca41ca91e60cc4cee2cd724d28b73534ace.zip | |
test: skip stringbytes-external-exceed-max on AIX
Add SKIP status for more tests in stringbytes-external-exceed-max that
are failing on AIX.
PR-URL: https://github.com/nodejs/node/pull/28516
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Diffstat (limited to 'test/addons')
| -rw-r--r-- | test/addons/addon.status | 19 | ||||
| -rw-r--r-- | test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js | 5 |
2 files changed, 19 insertions, 5 deletions
diff --git a/test/addons/addon.status b/test/addons/addon.status new file mode 100644 index 0000000000..ee094f4e51 --- /dev/null +++ b/test/addons/addon.status @@ -0,0 +1,19 @@ +prefix addons + +[true] # This section applies to all platforms + +[$system==aix] +# https://github.com/nodejs/build/issues/1820#issuecomment-505998851 +# https://github.com/nodejs/node/pull/28469 +# https://github.com/nodejs/node/pull/28516 +stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js: SKIP + +# https://github.com/nodejs/node/pull/28516 +stringbytes-external-exceed-max/test-stringbytes-external-at-max: SKIP +stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-ascii: SKIP +stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-base64: SKIP +stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-binary: SKIP +stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-hex: SKIP +stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-utf8: SKIP +stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-2: SKIP +stringbytes-external-exceed-max/test-stringbytes-external-exceed-max: SKIP diff --git a/test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js b/test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js index d6a442f751..d65144e04d 100644 --- a/test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js +++ b/test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js @@ -5,11 +5,6 @@ const skipMessage = 'intensive toString tests due to memory confinements'; if (!common.enoughTestMem) common.skip(skipMessage); -// See https://github.com/nodejs/build/issues/1820#issuecomment-505998851 -// See https://github.com/nodejs/node/pull/28469 -if (process.platform === 'aix') - common.skip('flaky on AIX'); - const binding = require(`./build/${common.buildType}/binding`); // v8 fails silently if string length > v8::String::kMaxLength |