diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2017-08-23 09:52:59 +0200 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2017-11-16 09:22:13 +0100 |
| commit | b021403b2afdab0f5077b55aa27286c187119acd (patch) | |
| tree | 7f43c95b7872ff024670a22c205b8b087f57880a /test/addons/zlib-binding | |
| parent | a0b1e2eca684a21e87dd8ae1d5becb4c85e4ddd4 (diff) | |
| download | android-node-v8-b021403b2afdab0f5077b55aa27286c187119acd.tar.gz android-node-v8-b021403b2afdab0f5077b55aa27286c187119acd.tar.bz2 android-node-v8-b021403b2afdab0f5077b55aa27286c187119acd.zip | |
test: --enable-static linked executable
The motivation for this commit is to enable projects embedding Node.js
and building with --enable-static to be able to run the test suite and
linter.
Currently when building with --enable-static no node executable
will be created which means that the tests (apart from the cctest) and
linter cannot be run.
This is currently a work in progress and works on MacOS but I need to
run the CI, and manually on different environments to verify that it
works as expected.
PR-URL: https://github.com/nodejs/node/pull/14986
Refs: https://github.com/nodejs/node/issues/14158
Refs: https://github.com/nodejs/node/pull/14892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Diffstat (limited to 'test/addons/zlib-binding')
| -rw-r--r-- | test/addons/zlib-binding/binding.gyp | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/test/addons/zlib-binding/binding.gyp b/test/addons/zlib-binding/binding.gyp index 60a9bb8266..24c3ae78a2 100644 --- a/test/addons/zlib-binding/binding.gyp +++ b/test/addons/zlib-binding/binding.gyp @@ -1,9 +1,22 @@ { + 'includes': ['../../../config.gypi'], + 'variables': { + 'node_target_type%': '', + }, 'targets': [ { 'target_name': 'binding', 'sources': ['binding.cc'], 'include_dirs': ['../../../deps/zlib'], + 'conditions': [ + ['node_target_type=="static_library"', { + 'conditions': [ + ['OS=="win"', { + 'libraries': ['../../../../$(Configuration)/lib/zlib.lib'], + }], + ], + }], + ], }, ] } |