summaryrefslogtreecommitdiff
path: root/test/addons/worker-buffer-callback/binding.cc
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2019-11-19 21:34:44 +0100
committerAnna Henningsen <anna@addaleax.net>2019-11-30 02:02:50 +0100
commitb7ef5937444c2693809f149acbb57457d75fe1bb (patch)
treef177e79a158dce59af8a2dbc28ad778e278e73b3 /test/addons/worker-buffer-callback/binding.cc
parentab2afa337979b5d26ad593b3863a900eb0c70e34 (diff)
downloadandroid-node-v8-b7ef5937444c2693809f149acbb57457d75fe1bb.tar.gz
android-node-v8-b7ef5937444c2693809f149acbb57457d75fe1bb.tar.bz2
android-node-v8-b7ef5937444c2693809f149acbb57457d75fe1bb.zip
buffer: release buffers with free callbacks on env exit
Invoke the free callback for a given `Buffer` if it was created with one, and mark the underlying `ArrayBuffer` as detached. This makes sure that the memory is released e.g. when addons inside Workers create such `Buffer`s. PR-URL: https://github.com/nodejs/node/pull/30551 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Diffstat (limited to 'test/addons/worker-buffer-callback/binding.cc')
-rw-r--r--test/addons/worker-buffer-callback/binding.cc11
1 files changed, 10 insertions, 1 deletions
diff --git a/test/addons/worker-buffer-callback/binding.cc b/test/addons/worker-buffer-callback/binding.cc
index a40876ebb5..1141c8a051 100644
--- a/test/addons/worker-buffer-callback/binding.cc
+++ b/test/addons/worker-buffer-callback/binding.cc
@@ -3,17 +3,24 @@
#include <v8.h>
using v8::Context;
+using v8::FunctionCallbackInfo;
using v8::Isolate;
using v8::Local;
using v8::Object;
using v8::Value;
+uint32_t free_call_count = 0;
char data[] = "hello";
+void GetFreeCallCount(const FunctionCallbackInfo<Value>& args) {
+ args.GetReturnValue().Set(free_call_count);
+}
+
void Initialize(Local<Object> exports,
Local<Value> module,
Local<Context> context) {
Isolate* isolate = context->GetIsolate();
+ NODE_SET_METHOD(exports, "getFreeCallCount", GetFreeCallCount);
exports->Set(context,
v8::String::NewFromUtf8(
isolate, "buffer", v8::NewStringType::kNormal)
@@ -22,7 +29,9 @@ void Initialize(Local<Object> exports,
isolate,
data,
sizeof(data),
- [](char* data, void* hint) {},
+ [](char* data, void* hint) {
+ free_call_count++;
+ },
nullptr).ToLocalChecked()).Check();
}