diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2018-01-20 01:00:34 +0100 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-01-21 02:19:46 +0100 |
| commit | d9b59def72c718aaad3eefb6bf43f409ccefe4d2 (patch) | |
| tree | ec02442a3153500b91e368c873db4d1a3763e567 /test/addons/openssl-client-cert-engine | |
| parent | c6682636be4955e2181c00e7d4868fbf6682a5c5 (diff) | |
| download | android-node-v8-d9b59def72c718aaad3eefb6bf43f409ccefe4d2.tar.gz android-node-v8-d9b59def72c718aaad3eefb6bf43f409ccefe4d2.tar.bz2 android-node-v8-d9b59def72c718aaad3eefb6bf43f409ccefe4d2.zip | |
build,test: make building addon tests less fragile
* Get rid of recursive `make` when building the node binary. An earlier
commit makes GYP write out rules that we can use for proper dependency
tracking.
* Use module name 'binding' in addons.md and addons-napi/*/binding.gyp.
This massively simplifies the logic for generating the build rules.
* Check in auto-generated add-on tests from `doc/api/addons.md`. The
files change rarely and generating them dynamically causes no end of
race conditions and special-casing during the build.
PR-URL: https://github.com/nodejs/node/pull/17407
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Diffstat (limited to 'test/addons/openssl-client-cert-engine')
| -rw-r--r-- | test/addons/openssl-client-cert-engine/binding.cc | 6 | ||||
| -rw-r--r-- | test/addons/openssl-client-cert-engine/binding.gyp | 4 |
2 files changed, 10 insertions, 0 deletions
diff --git a/test/addons/openssl-client-cert-engine/binding.cc b/test/addons/openssl-client-cert-engine/binding.cc new file mode 100644 index 0000000000..60340815ed --- /dev/null +++ b/test/addons/openssl-client-cert-engine/binding.cc @@ -0,0 +1,6 @@ +#include "node.h" +#include "v8.h" + +inline void Initialize(v8::Local<v8::Object>) {} + +NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize) diff --git a/test/addons/openssl-client-cert-engine/binding.gyp b/test/addons/openssl-client-cert-engine/binding.gyp index b069e43429..48a6aa3480 100644 --- a/test/addons/openssl-client-cert-engine/binding.gyp +++ b/test/addons/openssl-client-cert-engine/binding.gyp @@ -1,6 +1,10 @@ { 'targets': [ { + 'target_name': 'binding', + 'sources': [ 'binding.cc' ], + }, + { 'target_name': 'testengine', 'type': 'none', 'conditions': [ |