diff options
author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-11-07 07:50:51 +0100 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2018-11-09 21:26:31 -0800 |
commit | d58a0c628591a318b4692355f4a08140e17d61df (patch) | |
tree | 06ddbfef39956692b63530c252368710945c2b83 /test/addons/new-target | |
parent | a67e0a6fd21d09c3bca2c6211109e5be980b0b9d (diff) | |
download | android-node-v8-d58a0c628591a318b4692355f4a08140e17d61df.tar.gz android-node-v8-d58a0c628591a318b4692355f4a08140e17d61df.tar.bz2 android-node-v8-d58a0c628591a318b4692355f4a08140e17d61df.zip |
test: fix NewFromUtf8 compiler warning
Currently there are a number of compiler warnings like the following:
../binding.cc:6:41:
warning: 'NewFromUtf8' is deprecated:
Use maybe version [-Wdeprecated-declarations]
args.GetReturnValue().Set(v8::String::NewFromUtf8(isolate, "world"));
^
/node/deps/v8/include/v8.h:2883:10:
note: 'NewFromUtf8' has been explicitly marked deprecated here
static V8_DEPRECATE_SOON(
^
/node/deps/v8/include/v8config.h:341:29:
note: expanded from macro 'V8_DEPRECATE_SOON'
declarator __attribute__((deprecated(message)))
^
This commit updates the code to use the maybe versions.
PR-URL: https://github.com/nodejs/node/pull/24216
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test/addons/new-target')
-rw-r--r-- | test/addons/new-target/binding.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/test/addons/new-target/binding.cc b/test/addons/new-target/binding.cc index 21b932ae01..c2777c831e 100644 --- a/test/addons/new-target/binding.cc +++ b/test/addons/new-target/binding.cc @@ -12,7 +12,8 @@ inline void NewClass(const v8::FunctionCallbackInfo<v8::Value>& args) { inline void Initialize(v8::Local<v8::Object> binding) { auto isolate = binding->GetIsolate(); auto context = isolate->GetCurrentContext(); - binding->Set(v8::String::NewFromUtf8(isolate, "Class"), + binding->Set(v8::String::NewFromUtf8( + isolate, "Class", v8::NewStringType::kNormal).ToLocalChecked(), v8::FunctionTemplate::New(isolate, NewClass) ->GetFunction(context) .ToLocalChecked()); |