summaryrefslogtreecommitdiff
path: root/test/addons/make-callback
diff options
context:
space:
mode:
authorDaniel Bevenius <daniel.bevenius@gmail.com>2016-09-28 20:14:23 +0200
committerJames M Snell <jasnell@gmail.com>2016-10-06 10:27:30 -0700
commitfdca79fbc0a797206fa690d51b8844ed4fd596d6 (patch)
tree868cff27a76b16595ef6b832140a6f7ccd8dcd1d /test/addons/make-callback
parent47d1588e7562b0476715c40c4c323edc30308cae (diff)
downloadandroid-node-v8-fdca79fbc0a797206fa690d51b8844ed4fd596d6.tar.gz
android-node-v8-fdca79fbc0a797206fa690d51b8844ed4fd596d6.tar.bz2
android-node-v8-fdca79fbc0a797206fa690d51b8844ed4fd596d6.zip
test: enable addons test to pass with debug build
Currently when running configure with the --debug option in combination with the tests (./configure --debug && make -j8 test) there are a few addon tests that fail with error messages similar to this: === release test === Path: addons/load-long-path/test fs.js:558 return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode); ^ Error: ENOENT: no such file or directory, open '/nodejs/node/test/addons/load-long-path/build/Release/binding.node' at Object.fs.openSync (fs.js:558:18) at Object.fs.readFileSync (fs.js:468:33) at Object.<anonymous> (/nodejs/node/test/addons/load-long-path/test.js:28:19) at Module._compile (module.js:560:32) at Object.Module._extensions..js (module.js:569:10) at Module.load (module.js:477:32) at tryModuleLoad (module.js:436:12) at Function.Module._load (module.js:428:3) at Module.runMain (module.js:594:10) at run (bootstrap_node.js:382:7) Command: out/Release/node /nodejs/node/test/addons/load-long-path/test.js This commit allows for the tests to pass even if the configured build type is of type debug. PR-URL: https://github.com/nodejs/node/pull/8836 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test/addons/make-callback')
-rw-r--r--test/addons/make-callback/test.js2
1 files changed, 1 insertions, 1 deletions
diff --git a/test/addons/make-callback/test.js b/test/addons/make-callback/test.js
index f3c98770ef..43ad014c4a 100644
--- a/test/addons/make-callback/test.js
+++ b/test/addons/make-callback/test.js
@@ -3,7 +3,7 @@
const common = require('../../common');
const assert = require('assert');
const vm = require('vm');
-const binding = require('./build/Release/binding');
+const binding = require(`./build/${common.buildType}/binding`);
const makeCallback = binding.makeCallback;
assert.strictEqual(42, makeCallback(process, common.mustCall(function() {