summaryrefslogtreecommitdiff
path: root/test/addons/make-callback
diff options
context:
space:
mode:
authorTim Cheung <timch326@interchange.ubc.ca>2018-10-12 09:43:06 -0700
committerAnna Henningsen <anna@addaleax.net>2018-10-13 19:34:40 -0700
commit7f74515cd1622dcfbcc57327e613fa78b0be07f2 (patch)
treebf9e21cae2922a0f30938e42c354631f61e23cd5 /test/addons/make-callback
parente48d9aa873e7abec76cd27a8a50167f81574fccd (diff)
downloadandroid-node-v8-7f74515cd1622dcfbcc57327e613fa78b0be07f2.tar.gz
android-node-v8-7f74515cd1622dcfbcc57327e613fa78b0be07f2.tar.bz2
android-node-v8-7f74515cd1622dcfbcc57327e613fa78b0be07f2.zip
test: flip assertion arguments for make-callback/test.js
Assertion arguments should have the first value be the actual value, while the second value be the expected value. PR-URL: https://github.com/nodejs/node/pull/23470 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'test/addons/make-callback')
-rw-r--r--test/addons/make-callback/test.js34
1 files changed, 17 insertions, 17 deletions
diff --git a/test/addons/make-callback/test.js b/test/addons/make-callback/test.js
index efea43df3c..c5a71b5ab7 100644
--- a/test/addons/make-callback/test.js
+++ b/test/addons/make-callback/test.js
@@ -6,39 +6,39 @@ const vm = require('vm');
const binding = require(`./build/${common.buildType}/binding`);
const makeCallback = binding.makeCallback;
-assert.strictEqual(42, makeCallback(process, common.mustCall(function() {
- assert.strictEqual(0, arguments.length);
- assert.strictEqual(this, process);
+assert.strictEqual(makeCallback(process, common.mustCall(function() {
+ assert.strictEqual(arguments.length, 0);
+ assert.strictEqual(process, this);
return 42;
-})));
+})), 42);
-assert.strictEqual(42, makeCallback(process, common.mustCall(function(x) {
- assert.strictEqual(1, arguments.length);
- assert.strictEqual(this, process);
+assert.strictEqual(makeCallback(process, common.mustCall(function(x) {
+ assert.strictEqual(arguments.length, 1);
+ assert.strictEqual(process, this);
assert.strictEqual(x, 1337);
return 42;
-}), 1337));
+}), 1337), 42);
const recv = {
one: common.mustCall(function() {
- assert.strictEqual(0, arguments.length);
- assert.strictEqual(this, recv);
+ assert.strictEqual(arguments.length, 0);
+ assert.strictEqual(recv, this);
return 42;
}),
two: common.mustCall(function(x) {
- assert.strictEqual(1, arguments.length);
- assert.strictEqual(this, recv);
+ assert.strictEqual(arguments.length, 1);
+ assert.strictEqual(recv, this);
assert.strictEqual(x, 1337);
return 42;
}),
};
-assert.strictEqual(42, makeCallback(recv, 'one'));
-assert.strictEqual(42, makeCallback(recv, 'two', 1337));
+assert.strictEqual(makeCallback(recv, 'one'), 42);
+assert.strictEqual(makeCallback(recv, 'two', 1337), 42);
// Check that callbacks on a receiver from a different context works.
const foreignObject = vm.runInNewContext('({ fortytwo() { return 42; } })');
-assert.strictEqual(42, makeCallback(foreignObject, 'fortytwo'));
+assert.strictEqual(makeCallback(foreignObject, 'fortytwo'), 42);
// Check that the callback is made in the context of the receiver.
const target = vm.runInNewContext(`
@@ -48,7 +48,7 @@ const target = vm.runInNewContext(`
return Object;
})
`);
-assert.notStrictEqual(Object, makeCallback(process, target, Object));
+assert.notStrictEqual(makeCallback(process, target, Object), Object);
// Runs in inner context.
const forward = vm.runInNewContext(`
@@ -62,4 +62,4 @@ function endpoint($Object) {
throw new Error('bad');
return Object;
}
-assert.strictEqual(Object, makeCallback(process, forward, endpoint));
+assert.strictEqual(makeCallback(process, forward, endpoint), Object);