diff options
| author | Gabriel Schulhof <gabriel.schulhof@intel.com> | 2017-09-05 23:53:06 +0300 |
|---|---|---|
| committer | Gabriel Schulhof <gabriel.schulhof@intel.com> | 2017-09-10 00:15:49 +0300 |
| commit | 78286984da50ed7f0ed8914b587da62c552277ce (patch) | |
| tree | 8c690095a5c947a2b62796b8ff0828d5a62727d3 /test/addons/make-callback | |
| parent | a2b68723a920b9cc70377727ec0e3bbe11fbe548 (diff) | |
| download | android-node-v8-78286984da50ed7f0ed8914b587da62c552277ce.tar.gz android-node-v8-78286984da50ed7f0ed8914b587da62c552277ce.tar.bz2 android-node-v8-78286984da50ed7f0ed8914b587da62c552277ce.zip | |
test,doc: make module name match gyp target name
Currently the nm_modname does not match the file name of the resulting
module. In fact, the nm_modname is pretty arbitrary. This seeks to
introduce some consistency into the nm_modname property by having the
name of the module appear in exactly one place: the "target_name"
property of the gyp target that builds the module.
PR-URL: https://github.com/nodejs/node/pull/15209
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test/addons/make-callback')
| -rw-r--r-- | test/addons/make-callback/binding.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/addons/make-callback/binding.cc b/test/addons/make-callback/binding.cc index 3b56c385ec..a5dfe46d77 100644 --- a/test/addons/make-callback/binding.cc +++ b/test/addons/make-callback/binding.cc @@ -36,4 +36,4 @@ void Initialize(v8::Local<v8::Object> exports) { } // namespace -NODE_MODULE(binding, Initialize) +NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize) |