diff options
author | garygsc <garygsc@gmail.com> | 2019-10-26 02:54:18 -0600 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2019-11-30 18:08:59 +0100 |
commit | 79faa875026a275b3e5eca019b3c50e1cbe2e34e (patch) | |
tree | 0fb5327abc56edd199553a66ab3e6f8e0952f2bc /test/addons/make-callback-domain-warning | |
parent | c8930fb9bf647b88bba9b6e7be4f4ea119fb3d57 (diff) | |
download | android-node-v8-79faa875026a275b3e5eca019b3c50e1cbe2e34e.tar.gz android-node-v8-79faa875026a275b3e5eca019b3c50e1cbe2e34e.tar.bz2 android-node-v8-79faa875026a275b3e5eca019b3c50e1cbe2e34e.zip |
test: use arrow functions in addons tests
Convert all anonymous callback functions in `test/addons/**/*.js`
to use arrow functions, except for those in
`test/addons/make-callback/test.js` (which reference `this`)
`writing-tests.md` states to use arrow functions when appropriate.
PR-URL: https://github.com/nodejs/node/pull/30131
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Diffstat (limited to 'test/addons/make-callback-domain-warning')
-rw-r--r-- | test/addons/make-callback-domain-warning/test.js | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/test/addons/make-callback-domain-warning/test.js b/test/addons/make-callback-domain-warning/test.js index 2ea3c3f3d1..0377415e12 100644 --- a/test/addons/make-callback-domain-warning/test.js +++ b/test/addons/make-callback-domain-warning/test.js @@ -10,23 +10,23 @@ function makeCallback(object, cb) { } let latestWarning = null; -process.on('warning', function(warning) { +process.on('warning', (warning) => { latestWarning = warning; }); const d = domain.create(); // When domain is disabled, no warning will be emitted -makeCallback({ domain: d }, common.mustCall(function() { +makeCallback({ domain: d }, common.mustCall(() => { assert.strictEqual(latestWarning, null); - d.run(common.mustCall(function() { + d.run(common.mustCall(() => { // No warning will be emitted when no domain property is applied - makeCallback({}, common.mustCall(function() { + makeCallback({}, common.mustCall(() => { assert.strictEqual(latestWarning, null); // Warning is emitted when domain property is used and domain is enabled - makeCallback({ domain: d }, common.mustCall(function() { + makeCallback({ domain: d }, common.mustCall(() => { assert.strictEqual(latestWarning.name, 'DeprecationWarning'); assert.strictEqual(latestWarning.code, 'DEP0097'); })); |