diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-02-20 05:41:28 +0100 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-02-22 06:25:58 +0100 |
| commit | 53a5d87becb664c183d63a5c028641bc248f0771 (patch) | |
| tree | 5b71da97958e8cb729eaefd29952c572b0e490b4 /test/addons/make-callback-domain-warning | |
| parent | 2d76379e30ea1f31593f282ab7fb5368eddd2367 (diff) | |
| download | android-node-v8-53a5d87becb664c183d63a5c028641bc248f0771.tar.gz android-node-v8-53a5d87becb664c183d63a5c028641bc248f0771.tar.bz2 android-node-v8-53a5d87becb664c183d63a5c028641bc248f0771.zip | |
test: fix deprecation warning in binding.cc
Currently, the make-callback-domain-warning addon generates the
following warning:
../binding.cc:22:9:
warning: 'MakeCallback' is deprecated: Use MakeCallback(...,
async_context) [-Wdeprecated-declarations]
node::MakeCallback(isolate, recv, method, 0, nullptr);
^
../../../../src/node.h:172:50:
note: 'MakeCallback' has been explicitly marked
deprecated here
NODE_EXTERN v8::Local<v8::Value> MakeCallback(
^
1 warning generated.
This commit fixes this warning.
PR-URL: https://github.com/nodejs/node/pull/18877
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Diffstat (limited to 'test/addons/make-callback-domain-warning')
| -rw-r--r-- | test/addons/make-callback-domain-warning/binding.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/test/addons/make-callback-domain-warning/binding.cc b/test/addons/make-callback-domain-warning/binding.cc index c42166c745..d02c8f5176 100644 --- a/test/addons/make-callback-domain-warning/binding.cc +++ b/test/addons/make-callback-domain-warning/binding.cc @@ -19,7 +19,8 @@ void MakeCallback(const FunctionCallbackInfo<Value>& args) { Local<Object> recv = args[0].As<Object>(); Local<Function> method = args[1].As<Function>(); - node::MakeCallback(isolate, recv, method, 0, nullptr); + node::MakeCallback(isolate, recv, method, 0, nullptr, + node::async_context{0, 0}); } void Initialize(Local<Object> exports) { |