diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-11-08 11:43:50 +0100 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-11-11 08:02:30 +0100 |
| commit | faa584ab22b61a29c1d73b28d1cbfae5cbabab04 (patch) | |
| tree | b0d3e2c1b026f0ab58ef140b97412884583b4cb1 /test/addons/heap-profiler | |
| parent | 344d33eef110486bc094ba8d97a483379bf62752 (diff) | |
| download | android-node-v8-faa584ab22b61a29c1d73b28d1cbfae5cbabab04.tar.gz android-node-v8-faa584ab22b61a29c1d73b28d1cbfae5cbabab04.tar.bz2 android-node-v8-faa584ab22b61a29c1d73b28d1cbfae5cbabab04.zip | |
test: fix v8 Set/Get compiler warnings
PR-URL: https://github.com/nodejs/node/pull/24246
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'test/addons/heap-profiler')
| -rw-r--r-- | test/addons/heap-profiler/binding.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/addons/heap-profiler/binding.cc b/test/addons/heap-profiler/binding.cc index 29f58a5920..9e1e97e9fc 100644 --- a/test/addons/heap-profiler/binding.cc +++ b/test/addons/heap-profiler/binding.cc @@ -19,11 +19,11 @@ inline void Test(const v8::FunctionCallbackInfo<v8::Value>& args) { inline void Initialize(v8::Local<v8::Object> binding) { v8::Isolate* const isolate = binding->GetIsolate(); v8::Local<v8::Context> context = isolate->GetCurrentContext(); - binding->Set(v8::String::NewFromUtf8( + binding->Set(context, v8::String::NewFromUtf8( isolate, "test", v8::NewStringType::kNormal).ToLocalChecked(), v8::FunctionTemplate::New(isolate, Test) ->GetFunction(context) - .ToLocalChecked()); + .ToLocalChecked()).FromJust(); } NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize) |